postman-request - npm Package Compare versions

Comparing version 2.88.1-postman.4-beta.1 to 2.88.1-postman.5-beta.1

index.js

@@ -27,3 +27,3 @@ // Copyright 2010-2012 Mikeal Rogers
   var params = {}
-  if (typeof options === 'object') {
+  if (options !== null && typeof options === 'object') {
     extend(params, options, {uri: uri})
@@ -30,0 +30,0 @@ } else if (typeof uri === 'string') {

lib/auth.js

@@ -65,3 +65,3 @@ 'use strict'
   var re = /([a-z0-9_-]+)=(?:"([^"]+)"|([a-z0-9_-]+))/gi
-  for (;;) {
+  while (true) {
     var match = re.exec(authHeader)
@@ -68,0 +68,0 @@ if (!match) {

lib/har.js

@@ -175,3 +175,3 @@ 'use strict'
 
-      if (!param.fileName && !param.fileName && !param.contentType) {
+      if (!param.fileName && !param.contentType) {
         options.formData[param.name] = param.value
@@ -178,0 +178,0 @@ return

package.json

@@ -10,3 +10,3 @@ {
   ],
-  "version": "2.88.1-postman.4-beta.1",
+  "version": "2.88.1-postman.5-beta.1",
   "repository": {
@@ -46,3 +46,3 @@ "type": "git",
     "stream-length": "^1.0.2",
-    "tough-cookie": "~2.4.3",
+    "tough-cookie": "~2.5.0",
     "tunnel-agent": "^0.6.0",
@@ -49,0 +49,0 @@ "uuid": "^3.3.2"

request.js

@@ -907,4 +907,3 @@ 'use strict'
           socket.removeListener('connect', onReqSockConnect)
-          clearTimeout(self.timeoutTimer)
-          self.timeoutTimer = null
+          self.clearTimeout()
           setReqTimeout()
@@ -954,6 +953,3 @@ }
   }
-  if (self.timeout && self.timeoutTimer) {
-    clearTimeout(self.timeoutTimer)
-    self.timeoutTimer = null
-  }
+  self.clearTimeout()
   self.emit('error', error)
@@ -1045,6 +1041,3 @@ }
   }
-  if (self.timeout && self.timeoutTimer) {
-    clearTimeout(self.timeoutTimer)
-    self.timeoutTimer = null
-  }
+  self.clearTimeout()
 
@@ -1254,2 +1247,3 @@ var targetCookieJar = (self._jar && self._jar.setCookie) ? self._jar : globalCookieJar
 
+  self.clearTimeout()
   self.emit('abort')
@@ -1531,3 +1525,3 @@ }
   } else {
-    var targetCookieJar = (jar && jar.getCookieString) ? jar : globalCookieJar
+    var targetCookieJar = jar.getCookieString ? jar : globalCookieJar
     var urihref = self.uri.href
@@ -1616,2 +1610,3 @@ // fetch cookie in the Specified host
   var self = this
+  this.clearTimeout()
   if (!self._ended) {
@@ -1624,2 +1619,9 @@ self.end()
 
+Request.prototype.clearTimeout = function () {
+  if (this.timeoutTimer) {
+    clearTimeout(this.timeoutTimer)
+    this.timeoutTimer = null
+  }
+}
+
 Request.defaultProxyHeaderWhiteList =
@@ -1626,0 +1628,0 @@ Tunnel.defaultProxyHeaderWhiteList.slice()

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

2799

increased by0.04%

Worsened metrics

Total package byte prevSize

217729

decreased by-0.02%

Dependency changes

• + Addedtough-cookie@2.5.0(transitive)

• - Removedpunycode@1.4.1(transitive)

• - Removedtough-cookie@2.4.3(transitive)

• Updatedtough-cookie@~2.5.0