postman-url-encoder - npm Package Compare versions

Comparing version 2.1.0-beta.1 to 2.1.0-beta.2

encoder/index.js

@@ -85,8 +85,19 @@ /**
      */
-    domainToASCII = typeof url.domainToASCII === 'function' ?
-        // use faster internal method
-        url.domainToASCII :
+    domainToASCII = (function () {
+        var domainToASCII = url.domainToASCII;
+
+        // @note In Electron v3.1.8, the Node.js native url.domainToASCII
+        // doesn't work as expected. ¯\_(ツ)_/¯
+        // so, check if it convert's '😎' to 'xn--s28h' or not.
+        // @todo Remove this hack on Electron >= 4
+        /* istanbul ignore next */
+        if (typeof domainToASCII === 'function' && domainToASCII('😎') === 'xn--s28h') {
+            // use faster native method
+            return domainToASCII;
+        }
+
         // else, lazy load `punycode` dependency
         /* istanbul ignore next */
-        require('punycode').toASCII;
+        return require('punycode').toASCII;
+    }());
 
@@ -93,0 +104,0 @@ /**

package.json

@@ -5,3 +5,3 @@ {
   "author": "Postman Labs <[e-mail]>",
-  "version": "2.1.0-beta.1",
+  "version": "2.1.0-beta.2",
   "license": "Apache-2.0",
@@ -8,0 +8,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

160511

increased by0.34%

Lines of code

3505

increased by0.26%

No dependency changes