promisify-child-process - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

lib/index.js

@@ -33,3 +33,3 @@ 'use strict';
     if (options.encoding && options.encoding !== 'buffer') {
-      stdout = child.stdout && child.stdout.readable ? '' : null, stderr = child.stderr && child.stderr.readable ? '' : null;
+      stdout = child.stdout ? '' : null, stderr = child.stderr ? '' : null;
       if (stdout != null) child.stdout.on('data', function (data) {
@@ -42,3 +42,3 @@ return stdout += data;
     } else {
-      stdout = child.stdout && child.stdout.readable ? Buffer.alloc(0) : null, stderr = child.stderr && child.stderr.readable ? Buffer.alloc(0) : null;
+      stdout = child.stdout ? Buffer.alloc(0) : null, stderr = child.stderr ? Buffer.alloc(0) : null;
       if (stdout != null) child.stdout.on('data', function (data) {
@@ -45,0 +45,0 @@ return stdout = Buffer.concat([stdout, data]);

package.json

 {
   "name": "promisify-child-process",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "seriously like the best async child process library",
@@ -57,3 +57,4 @@ "main": "lib/index.js",
     "@commitlint/config-conventional": "^6.0.2",
-    "@jedwards1211/eslint-config": "^1.0.0",
+    "@jedwards1211/commitlint-config": "^1.0.0",
+    "@jedwards1211/eslint-config": "^2.0.0",
     "@jedwards1211/eslint-config-flow": "^1.0.0",
@@ -76,3 +77,3 @@ "babel-cli": "^6.23.0",
     "eslint-watch": "^3.0.0",
-    "flow-bin": "^0.65.0",
+    "flow-bin": "^0.70.0",
     "flow-copy-source": "^1.2.1",
@@ -85,5 +86,5 @@ "flow-watch": "^1.1.0",
     "rimraf": "^2.6.0",
-    "semantic-release": "^12.2.2",
+    "semantic-release": "^15.1.4",
     "travis-deploy-once": "^4.3.1"
   }
 }

src/index.js

@@ -22,9 +22,9 @@ // @flow
     if (options.encoding && options.encoding !== 'buffer') {
-      stdout = (child.stdout && child.stdout.readable) ? '' : null,
-      stderr = (child.stderr && child.stderr.readable) ? '' : null
+      stdout = child.stdout ? '' : null,
+      stderr = child.stderr ? '' : null
       if (stdout != null) child.stdout.on('data', (data) => stdout += data)
       if (stderr != null) child.stderr.on('data', (data) => stderr += data)
     } else {
-      stdout = (child.stdout && child.stdout.readable) ? Buffer.alloc(0) : null,
-      stderr = (child.stderr && child.stderr.readable) ? Buffer.alloc(0) : null
+      stdout = child.stdout ? Buffer.alloc(0) : null,
+      stderr = child.stderr ? Buffer.alloc(0) : null
       if (stdout != null) child.stdout.on('data', (data) => stdout = Buffer.concat([ (stdout: any), data ]))
@@ -31,0 +31,0 @@ if (stderr != null) child.stderr.on('data', (data) => stderr = Buffer.concat([ (stderr: any), data ]))

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

432703

increased by0.43%

Worsened metrics

Dev dependency count

31

increased by3.33%

No dependency changes