pubnub - npm Package Compare versions

Comparing version 4.0.12 to 4.0.13

bower.json

 {
   "name": "pubnub",
-  "version": "4.0.12",
+  "version": "4.0.13",
   "main": "dist/web/pubnub.min.js",
@@ -5,0 +5,0 @@ "license": "https://github.com/pubnub/javascript/blob/master/LICENSE",

CHANGELOG.md

 
+## [v4.0.13](https://github.com/pubnub/javascript/tree/v4.0.13)
+
+
+  [Full Changelog](https://github.com/pubnub/javascript/compare/v4.0.12...v4.0.13)
+
+
+- ⭐propogate status events to the status callback on subscribe operations.
+
+
+
 ## [v4.0.12](https://github.com/pubnub/javascript/tree/v4.0.12)
@@ -8,3 +18,3 @@
 
-- ⭐affectedChannels and affectedChannelGroups are now populated on subscribe / unsubscribe events2
+- ⭐affectedChannels and affectedChannelGroups are now populated on subscribe / unsubscribe events
 
@@ -11,0 +21,0 @@

lib/core/components/subscription_manager.js

@@ -286,5 +286,3 @@ 'use strict';
           this._startSubscribeLoop();
-        }
-
-        if (status.category === _categories2.default.PNNetworkIssuesCategory) {
+        } else if (status.category === _categories2.default.PNNetworkIssuesCategory) {
           this.disconnect();
@@ -302,2 +300,4 @@ this._reconnectionManager.onReconnection(function () {
           this._listenerManager.announceStatus(status);
+        } else {
+          this._listenerManager.announceStatus(status);
         }
@@ -304,0 +304,0 @@

package.json

 {
   "name": "pubnub",
   "preferGlobal": false,
-  "version": "4.0.12",
+  "version": "4.0.13",
   "author": "PubNub <[e-mail]>",
@@ -45,3 +45,3 @@ "description": "Publish & Subscribe Real-time Messaging with PubNub",
     "eslint-plugin-flowtype": "2.19.0",
-    "eslint-plugin-import": "^2.0.0",
+    "eslint-plugin-import": "^1.16.0",
     "eslint-plugin-mocha": "4.6.0",
@@ -48,0 +48,0 @@ "eslint-plugin-react": "6.3.0",

README.md

@@ -20,3 +20,3 @@ # PubNub JavaScript SDK (V4)
 ## CDN Links
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.0.12.min.js
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.0.12.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.0.13.min.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.0.13.js

src/core/components/subscription_manager.js

@@ -258,6 +258,4 @@ /* @flow */
         this._startSubscribeLoop();
-      }
-
-      // we lost internet connection, alert the reconnection manager and terminate all loops
-      if (status.category === categoryConstants.PNNetworkIssuesCategory) {
+      } else if (status.category === categoryConstants.PNNetworkIssuesCategory) {
+        // we lost internet connection, alert the reconnection manager and terminate all loops
         this.disconnect();
@@ -275,2 +273,4 @@ this._reconnectionManager.onReconnection(() => {
         this._listenerManager.announceStatus(status);
+      } else {
+        this._listenerManager.announceStatus(status);
       }
@@ -277,0 +277,0 @@

test/integration/operations/heartbeat.test.js

@@ -74,5 +74,7 @@ /* global describe, beforeEach, it, before, afterEach, after */
         status(status) {
-          assert.equal(status.error, false);
-          assert.equal(scope.isDone(), true);
-          done();
+          if (status.operation === 'PNHeartbeatOperation' && !status.error) {
+            assert.equal(status.error, false);
+            assert.equal(scope.isDone(), true);
+            done();
+          }
         }
@@ -91,5 +93,7 @@ });
         status(status) {
-          assert.equal(status.error, false);
-          assert.equal(scope.isDone(), true);
-          done();
+          if (status.operation === 'PNHeartbeatOperation' && !status.error) {
+            assert.equal(status.error, false);
+            assert.equal(scope.isDone(), true);
+            done();
+          }
         }
@@ -96,0 +100,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1254454

increased by0.09%

Lines of code

12274

increased by0.06%

No dependency changes