pubnub - npm Package Compare versions

Comparing version 4.28.3 to 4.28.4

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [v4.28.4](https://github.com/pubnub/javascript/releases/tag/v4.28.4)
+July-15-2020
+
+[Full Changelog](https://github.com/pubnub/javascript/compare/v4.28.3...v4.28.4)
+
+- 🐛 Fixes issue of high cpu usage when heartbeat interval is not set. 
+
 ## [v4.28.3](https://github.com/pubnub/javascript/releases/tag/v4.28.3)
@@ -2,0 +9,0 @@ July-15-2020

lib/core/components/config.js

@@ -266,3 +266,3 @@ "use strict";
     value: function getVersion() {
-      return '4.28.3';
+      return '4.28.4';
     }
@@ -269,0 +269,0 @@ }, {

lib/core/components/subscription_manager.js

@@ -371,3 +371,3 @@ "use strict";
 
-      if (this._config.getHeartbeatInterval() === 0) {
+      if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
         return;
@@ -374,0 +374,0 @@ }

package.json

 {
   "name": "pubnub",
-  "version": "4.28.3",
+  "version": "4.28.4",
   "author": "PubNub <[e-mail]>",
@@ -5,0 +5,0 @@ "description": "Publish & Subscribe Real-time Messaging with PubNub",

README.md

@@ -25,3 +25,3 @@ # PubNub JavaScript SDK (V4)
 
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.3.min.js
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.3.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.4.min.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.4.js

src/core/components/config.js

@@ -310,3 +310,3 @@ /* @flow */
   getVersion(): string {
-    return '4.28.3';
+    return '4.28.4';
   }
@@ -313,0 +313,0 @@

src/core/components/subscription_manager.js

@@ -353,4 +353,4 @@ /* @flow */
 
-    // if the interval is 0, do not queue up heartbeating
-    if (this._config.getHeartbeatInterval() === 0) {
+    // if the interval is 0 or undefined, do not queue up heartbeating
+    if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
       return;
@@ -357,0 +357,0 @@ }

test/integration/operations/heartbeat.test.js

@@ -26,2 +26,3 @@ /* global describe, beforeEach, it, before, afterEach, after */
       uuid: 'myUUID',
+      heartbeatInterval	:1, // for quick test of heartbeat calls
       announceSuccessfulHeartbeats: true,
@@ -28,0 +29,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

5245071

increased by0.02%

Lines of code

47786

No dependency changes