pubnub - npm Package Compare versions

Comparing version 4.3.1 to 4.3.2

lib/core/components/config.js

@@ -15,6 +15,2 @@ 'use strict';
 
-var _package = require('../../../package.json');
-
-var _package2 = _interopRequireDefault(_package);
-
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -170,3 +166,3 @@
     value: function getVersion() {
-      return _package2.default.version;
+      return '4.3.2';
     }
@@ -173,0 +169,0 @@ }, {

lib/core/pubnub-common.js

@@ -125,6 +125,2 @@ 'use strict';
 
-var _package = require('../../package.json');
-
-var _package2 = _interopRequireDefault(_package);
-
 var _operations = require('./constants/operations');
@@ -253,3 +249,3 @@
     value: function getVersion() {
-      return _package2.default.version;
+      return this._config.getVersion();
     }
@@ -256,0 +252,0 @@ }, {

package.json

 {
   "name": "pubnub",
-  "version": "4.3.1",
+  "version": "4.3.2",
   "author": "PubNub <[e-mail]>",
@@ -5,0 +5,0 @@ "description": "Publish & Subscribe Real-time Messaging with PubNub",

README.md

@@ -21,3 +21,3 @@ # PubNub JavaScript SDK (V4)
 ## CDN Links
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.3.1.min.js
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.3.1.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.3.2.min.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.3.2.js

src/core/components/config.js

@@ -6,3 +6,2 @@ /* @flow */
 import { InternalSetupStruct, DatabaseInterface } from '../flow_interfaces';
-import packageJSON from '../../../package.json';
 
@@ -191,3 +190,3 @@ type ConfigConstructArgs = {
   getVersion(): string {
-    return packageJSON.version;
+    return '4.3.2';
   }
@@ -194,0 +193,0 @@

src/core/pubnub-common.js

@@ -40,3 +40,2 @@ /* @flow */
 
-import packageJSON from '../../package.json';
 import OPERATIONS from './constants/operations';
@@ -211,4 +210,4 @@ import CATEGORIES from './constants/categories';
 
-  getVersion(): String {
-    return packageJSON.version;
+  getVersion(): string {
+    return this._config.getVersion();
   }
@@ -215,0 +214,0 @@

test/release/release.test.js

 /* global describe, it, __dirname */
 
+import PubNub from '../../lib/node/index';
+
 let assert = require('assert');
@@ -28,2 +30,6 @@ let fs = require('fs');
 
+  it('with correct version in code', () => {
+    assert.equal(packageJSON.version, new PubNub({}).getVersion());
+  });
+
   it('with updated readme', () => {
@@ -30,0 +36,0 @@ assert(readMe.indexOf('https://cdn.pubnub.com/sdk/javascript/pubnub.' + packageJSON.version + '.js') > 1);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

1553867

decreased by-0.86%

Lines of code

12867

decreased by-0.76%

No dependency changes