pull-write - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

index.js

@@ -7,2 +7,4 @@ //another idea: buffer 2* the max, but only call write with half of that,
 
+var Looper = require('looper')
+
 function append (array, item) {
@@ -19,16 +21,26 @@ (array = array || []).push(item)
     _read = read
-    if(ended) return read(ended, function (err) {
-      cb(err)
-      _cb && _cb()
-    })
+    if(ended)
+      return read(ended, function (err) {
+        cb(err); _cb && _cb()
+      })
 
     var reading = false
-    function more () {
-      if(reading || ended) return
-      reading = true
-      read(null, function (err, data) {
-        reading = false
-        next(err, data)
+    var more = Looper(function () {
+        if(reading || ended) return
+        reading = true
+        read(null, function (err, data) {
+          reading = false
+          ;(function (end, data) {
+            if(ended) return
+            ended = end
+            if(!ended) {
+              queue = reduce(queue, data)
+              length = (queue && queue.length) || 0
+              if(queue != null) flush()
+              if(length < max) more()
+            }
+            else if(!writing) cb(ended === true ? null : ended)
+          })(err, data)
+        })
       })
-    }
 
@@ -53,14 +65,2 @@ function flush () {
 
-    function next (end, data) {
-      if(ended) return
-      ended = end
-      if(!ended) {
-        queue = reduce(queue, data)
-        length = (queue && queue.length) || 0
-        if(queue != null) flush()
-        if(length < max) more()
-      }
-      else if(!writing) cb(ended === true ? null : ended)
-    }
-
     reader.abort = function (__cb) {
@@ -67,0 +67,0 @@ _cb = function (end) {

package.json

 {
   "name": "pull-write",
   "description": "",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "homepage": "https://github.com/dominictarr/pull-write",
@@ -11,2 +11,3 @@ "repository": {
   "dependencies": {
+    "looper": "^4.0.0",
     "pull-cat": "^1.1.11",
@@ -13,0 +14,0 @@ "pull-stream": "^3.4.5"

test/index.js

@@ -193,2 +193,18 @@ var tape = require('tape')
 
+tape('range error', function (t) {
+  var len = 0
+  pull(
+    pull.count(10000),
+    createWrite(function (data, cb) {
+      len += data.length
+      cb()
+    }, function (a, b) {
+      if(!a) return [b]
+      return a.concat(b)
+    }, 100, function (err) {
+      t.equal(len, 10001)
+      t.end()
+    })
+  )
+})
 

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

10098

increased by4.19%

Lines of code

258

increased by6.61%

Worsened metrics

Dependency count

3

increased by50%

Number of package files

6

decreased by-14.29%

Dependency changes

• + Addedlooper@^4.0.0

• + Addedlooper@4.0.0(transitive)