qs - npm Package Compare versions

Comparing version 0.0.2 to 0.0.3

._benchmark.js

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���"
�"com.macromates.caret{
+Mac OS X        	2��ATTR<�;��"
�"com.macromates.caret{
     column = 15;
     line = 3;
 }

._examples.js

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���#
�#com.macromates.caret{
+Mac OS X        	2��ATTR<�=��#
�#com.macromates.caret{
     column = 31;
     line = 10;
 }

._History.md

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���!
�!com.macromates.caret{
+Mac OS X        	2��ATTR<�?��!
�!com.macromates.caret{
     column = 0;
     line = 5;
 }

._index.js

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���"
�"com.macromates.caret{
+Mac OS X        	2��ATTR<�A��"
�"com.macromates.caret{
     column = 32;
     line = 1;
 }

._package.json

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���"
�"com.macromates.caret{
+Mac OS X        	2��ATTR<�F��"
�"com.macromates.caret{
     column = 19;
     line = 3;
 }

._Readme.md

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���"
�"com.macromates.caret{
+Mac OS X        	2��ATTR<�H��"
�"com.macromates.caret{
     column = 20;
     line = 7;
 }

History.md

 
+0.0.3 / 2011-02-08 
+==================
+
+  * Fixed case when right-hand value contains "]"
+
 0.0.2 / 2011-02-07 
@@ -3,0 +8,0 @@ ==================

lib/._querystring.js

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/a	��#
�#com.macromates.caret{
+Mac OS X        	2��ATTR<�|��#
�#com.macromates.caret{
     column = 24;
     line = 11;
 }

lib/querystring.js

@@ -12,3 +12,3 @@
 
-exports.version = '0.0.2';
+exports.version = '0.0.3';
 
@@ -28,4 +28,4 @@ /**
       var pair = decodeURIComponent(pair)
-        , brace = pair.lastIndexOf(']') + 1
         , eql = pair.indexOf('=')
+        , brace = lastBraceInKey(pair)
         , key = pair.substr(0, brace || eql)
@@ -75,2 +75,22 @@ , val = pair.substr(brace || eql, pair.length)
     }, {});
-};
+};
+
+/**
+ * Locate last brace in `str` within the key.
+ *
+ * @param {String} str
+ * @return {Number}
+ * @api private
+ */
+
+function lastBraceInKey(str) {
+  var len = str.length
+    , brace
+    , c;
+  for (var i = 0; i < len; ++i) {
+    c = str[i];
+    if (']' == c) brace = false;
+    if ('[' == c) brace = true;
+    if ('=' == c && !brace) return i;
+  }
+}

package.json

 {
   "name": "qs",
   "description": "querystring parser",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "repository": {},
@@ -6,0 +6,0 @@ "author": "TJ Holowaychuk <[e-mail]> (http://tjholowaychuk.com)",

test/._querystring.test.js

@@ -1,4 +0,4 @@
-Mac OS X        	2��ATTR/`���#
�#com.macromates.caret{
-    column = 13;
-    line = 51;
+Mac OS X        	2��ATTR<�L��#
�#com.macromates.caret{
+    column = 62;
+    line = 93;
 }

test/querystring.test.js

@@ -83,2 +83,16 @@
   
+  'test right-hand brackets': function(){
+    qs.parse('pets=["tobi"]')
+      .should.eql({ pets: '["tobi"]' });
+
+    qs.parse('operators=[">=", "<="]')
+      .should.eql({ operators: '[">=", "<="]' });
+
+    qs.parse('op[>=]=[1,2,3]')
+      .should.eql({ op: { '>=': '[1,2,3]' }});
+
+    qs.parse('op[>=]=[1,2,3]&op[=]=[[[[1]]]]')
+          .should.eql({ op: { '>=': '[1,2,3]', '=': '[[[[1]]]]' }});
+  },
+  
   // 'test complex': function(){
@@ -85,0 +99,0 @@ //   qs.parse('users[][name][first]=tj&users[foo]=bar')

No alert changes

Improved metrics

Total package byte prevSize

173107

increased by0.49%

Lines of code

1390

increased by2.06%

No dependency changes