raven - npm Package Compare versions

Comparing version 2.6.0 to 2.6.1

History.md

 # Changelog
 
+## 2.6.1 - 2018-05-10
+
+- fix: correctly detect errors from vm (#457)
+- ref: use console.warn for alerts and store them in Set (#455)
+- ci: Add node 9 and 10 to travis builds (#456)
+
 ## 2.6.0 - 2018-04-24
@@ -4,0 +10,0 @@

lib/client.js

@@ -369,3 +369,3 @@ 'use strict';
 
-    if (!(err instanceof Error)) {
+    if (!utils.isError(err)) {
       if (utils.isPlainObject(err)) {
@@ -455,3 +455,3 @@ // This will allow us to group events based on top-level keys
       var err = arguments[0];
-      if (err instanceof Error) {
+      if (utils.isError(err)) {
         self.captureException(err, options);
@@ -458,0 +458,0 @@ } else {

lib/utils.js

@@ -18,3 +18,3 @@ 'use strict';
 
-var consoleAlerts = {};
+var consoleAlerts = new Set();
 
@@ -35,2 +35,10 @@ // Default Node.js REPL depth
 
+function isError(what) {
+  return (
+    Object.prototype.toString.call(what) === '[object Error]' || what instanceof Error
+  );
+}
+
+module.exports.isError = isError;
+
 function isPlainObject(what) {
@@ -128,5 +136,9 @@ return Object.prototype.toString.call(what) === '[object Object]';
 
+module.exports.enableConsoleAlerts = function enableConsoleAlerts() {
+  consoleAlerts = new Set();
+};
+
 module.exports.consoleAlert = function consoleAlert(msg) {
   if (consoleAlerts) {
-    console.log('raven@' + ravenVersion + ' alert: ' + msg);
+    console.warn('raven@' + ravenVersion + ' alert: ' + msg);
   }
@@ -136,5 +148,5 @@ };
 module.exports.consoleAlertOnce = function consoleAlertOnce(msg) {
-  if (consoleAlerts && !(msg in consoleAlerts)) {
-    consoleAlerts[msg] = true;
-    console.log('raven@' + ravenVersion + ' alert: ' + msg);
+  if (consoleAlerts && !consoleAlerts.has(msg)) {
+    consoleAlerts.add(msg);
+    console.warn('raven@' + ravenVersion + ' alert: ' + msg);
   }
@@ -141,0 +153,0 @@ };

package.json

@@ -12,3 +12,3 @@ {
   ],
-  "version": "2.6.0",
+  "version": "2.6.1",
   "repository": "git://github.com/getsentry/raven-node.git",
@@ -23,6 +23,6 @@ "license": "BSD-2-Clause",
   "scripts": {
-    "lint": "node_modules/eslint/bin/eslint.js .",
+    "lint": "eslint . --quiet",
     "precommit": "lint-staged",
     "pretest": "npm install && npm run lint",
-    "test": "NODE_ENV=test istanbul cover _mocha  -- --reporter dot && NODE_ENV=test node_modules/coffee-script/bin/coffee ./test/run.coffee",
+    "test": "NODE_ENV=test istanbul cover _mocha  -- --reporter dot && NODE_ENV=test coffee ./test/run.coffee",
     "test-mocha": "NODE_ENV=test mocha",
@@ -29,0 +29,0 @@ "test-full": "npm run test && cd test/instrumentation && ./run.sh"

No alert changes

Improved metrics

Total package byte prevSize

69032

increased by0.58%

Lines of code

1414

increased by0.64%

No dependency changes