raven - npm Package Compare versions

Comparing version 2.6.2 to 2.6.3

lib/client.js

@@ -235,4 +235,8 @@ 'use strict';
     kwargs.extra = extend({}, globalContext.extra, domainContext.extra, kwargs.extra);
+    // Perform a shallow copy of breadcrums to not send one that we'll capture below through as well
     kwargs.breadcrumbs = {
-      values: domainContext.breadcrumbs || globalContext.breadcrumbs || []
+      values:
+        (domainContext.breadcrumbs && domainContext.breadcrumbs.slice()) ||
+        (globalContext.breadcrumbs && globalContext.breadcrumbs.slice()) ||
+        []
     };
@@ -248,3 +252,3 @@
       */
-    kwargs.request = this._createRequestObject(
+    var request = this._createRequestObject(
       globalContext.request,
@@ -254,4 +258,6 @@ domainContext.request,
     );
-    if (Object.keys(kwargs.request).length === 0) {
-      var req = this._createRequestObject(
+    delete kwargs.request;
+
+    if (Object.keys(request).length === 0) {
+      request = this._createRequestObject(
         globalContext.req,
@@ -261,9 +267,12 @@ domainContext.req,
       );
-      if (Object.keys(req).length > 0) {
-        var parseUser = Object.keys(kwargs.user).length === 0 ? this.parseUser : false;
-        extend(kwargs, parsers.parseRequest(req, parseUser));
-        delete kwargs.req;
-      }
+      delete kwargs.req;
     }
 
+    if (Object.keys(request).length > 0) {
+      var parseUser = Object.keys(kwargs.user).length === 0 ? this.parseUser : false;
+      extend(kwargs, parsers.parseRequest(request, parseUser));
+    } else {
+      kwargs.request = {};
+    }
+
     kwargs.modules = utils.getModules();
@@ -295,2 +304,11 @@ kwargs.server_name = kwargs.server_name || this.name;
 
+    // Capture breadcrumb before sending it, as we also want to have it even when
+    // it was dropped due to sampleRate or shouldSendCallback
+    this.captureBreadcrumb({
+      category: 'sentry',
+      message: kwargs.message,
+      event_id: kwargs.event_id,
+      level: kwargs.level || 'error' // presume error unless specified
+    });
+
     var shouldSend = true;
@@ -297,0 +315,0 @@ if (!this._enabled) shouldSend = false;

package.json

@@ -12,6 +12,6 @@ {
   ],
-  "version": "2.6.2",
-  "repository": "git://github.com/getsentry/raven-node.git",
+  "version": "2.6.3",
+  "repository": "git://github.com/getsentry/raven-js.git",
   "license": "BSD-2-Clause",
-  "homepage": "https://github.com/getsentry/raven-node",
+  "homepage": "https://github.com/getsentry/raven-js",
   "author": "Matt Robenolt <[e-mail]>",
@@ -23,5 +23,3 @@ "main": "index.js",
   "scripts": {
-    "lint": "eslint . --quiet",
-    "precommit": "lint-staged",
-    "pretest": "npm install && npm run lint",
+    "lint": "eslint .",
     "test": "NODE_ENV=test istanbul cover _mocha  -- --reporter dot && NODE_ENV=test coffee ./test/run.coffee",
@@ -48,5 +46,3 @@ "test-mocha": "NODE_ENV=test mocha",
     "glob": "~3.1.13",
-    "husky": "^0.14.3",
     "istanbul": "^0.4.3",
-    "lint-staged": "^4.0.4",
     "mocha": "~3.1.2",
@@ -62,9 +58,3 @@ "nock": "~9.0.0",
     "printWidth": 90
-  },
-  "lint-staged": {
-    "*.js": [
-      "prettier --write",
-      "git add"
-    ]
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Improved metrics

Dev dependency count

12

decreased by-14.29%

Lines of code

1431

increased by1.06%

Worsened metrics

Total package byte prevSize

68911

decreased by-0.38%

Number of package files

15

decreased by-6.25%

Number of low license alerts

1

increased byInfinity%

Number of medium quality alerts

1

increased byInfinity%

Number of lines in readme file

0

decreased by-100%

No dependency changes