rc-color-picker - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

lib/Alpha.js

@@ -55,2 +55,7 @@ 'use strict';
   _createClass(Alpha, [{
+    key: 'componentWillUnmount',
+    value: function componentWillUnmount() {
+      this.removeListeners();
+    }
+  }, {
     key: 'onMouseDown',
@@ -85,10 +90,3 @@ value: function onMouseDown(e) {
       });
-      if (this.dragListener) {
-        this.dragListener.remove();
-        this.dragListener = null;
-      }
-      if (this.dragUpListener) {
-        this.dragUpListener.remove();
-        this.dragUpListener = null;
-      }
+      this.removeListeners();
     }
@@ -127,2 +125,14 @@ }, {
   }, {
+    key: 'removeListeners',
+    value: function removeListeners() {
+      if (this.dragListener) {
+        this.dragListener.remove();
+        this.dragListener = null;
+      }
+      if (this.dragUpListener) {
+        this.dragUpListener.remove();
+        this.dragUpListener = null;
+      }
+    }
+  }, {
     key: 'render',
@@ -129,0 +139,0 @@ value: function render() {

lib/Board.js

@@ -54,2 +54,7 @@ 'use strict';
   _createClass(Board, [{
+    key: 'componentWillUnmount',
+    value: function componentWillUnmount() {
+      this.removeListeners();
+    }
+  }, {
     key: 'onBoardMouseDown',
@@ -85,2 +90,12 @@ value: function onBoardMouseDown(e) {
       });
+      this.removeListeners();
+    }
+  }, {
+    key: 'getPrefixCls',
+    value: function getPrefixCls() {
+      return this.props.rootPrefixCls + '-board';
+    }
+  }, {
+    key: 'removeListeners',
+    value: function removeListeners() {
       if (this.dragListener) {
@@ -95,7 +110,2 @@ this.dragListener.remove();
     }
-  }, {
-    key: 'getPrefixCls',
-    value: function getPrefixCls() {
-      return this.props.rootPrefixCls + '-board';
-    }
 
@@ -102,0 +112,0 @@ /**

lib/Ribbon.js

@@ -50,2 +50,7 @@ 'use strict';
   _createClass(Ribbon, [{
+    key: 'componentWillUnmount',
+    value: function componentWillUnmount() {
+      this.removeListeners();
+    }
+  }, {
     key: 'onMouseDown',
@@ -80,10 +85,3 @@ value: function onMouseDown(e) {
       });
-      if (this.dragListener) {
-        this.dragListener.remove();
-        this.dragListener = null;
-      }
-      if (this.dragUpListener) {
-        this.dragUpListener.remove();
-        this.dragUpListener = null;
-      }
+      this.removeListeners();
     }
@@ -112,2 +110,14 @@ }, {
   }, {
+    key: 'removeListeners',
+    value: function removeListeners() {
+      if (this.dragListener) {
+        this.dragListener.remove();
+        this.dragListener = null;
+      }
+      if (this.dragUpListener) {
+        this.dragUpListener.remove();
+        this.dragUpListener = null;
+      }
+    }
+  }, {
     key: 'render',
@@ -114,0 +124,0 @@ value: function render() {

package.json

 {
   "name": "rc-color-picker",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "color-picker ui component for react",
@@ -57,2 +57,2 @@ "main": "lib/index.js",
   ]
-}
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

1743

increased by1.75%

Worsened metrics

Total package byte prevSize

67638

decreased by-4.01%

Number of package files

12

decreased by-7.69%

Number of medium quality alerts

1

increased byInfinity%

Number of lines in readme file

0

decreased by-100%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes