react-aria-modal - npm Package Compare versions

Comparing version 2.12.0 to 2.12.1

CHANGELOG.md

 # Changelog
 
+## 2.12.1
+
+- Fix bug that was blocking changes to the `scrollDisabled` prop *while the modal is open*.
+
 ## 2.12.0
@@ -4,0 +8,0 @@

dist/react-aria-modal.js

@@ -53,6 +53,2 @@ 'use strict';
       }
-
-      if (this.props.scrollDisabled) {
-        noScroll.on();
-      }
     }
@@ -78,4 +74,17 @@ }, {
       }
+
+      if (this.props.scrollDisabled) {
+        noScroll.on();
+      }
     }
   }, {
+    key: 'componentDidUpdate',
+    value: function componentDidUpdate(prevProps) {
+      if (prevProps.scrollDisabled && !this.props.scrollDisabled) {
+        noScroll.off();
+      } else if (!prevProps.scrollDisabled && this.props.scrollDisabled) {
+        noScroll.on();
+      }
+    }
+  }, {
     key: 'componentWillUnmount',
@@ -82,0 +91,0 @@ value: function componentWillUnmount() {

package.json

 {
   "name": "react-aria-modal",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "description": "A fully accessible and flexible React modal built according WAI-ARIA Authoring Practices",
@@ -5,0 +5,0 @@ "main": "dist/react-aria-modal.js",

src/react-aria-modal.js

@@ -24,6 +24,2 @@ const React = require('react');
     }
-
-    if (this.props.scrollDisabled) {
-      noScroll.on();
-    }
   }
@@ -48,4 +44,16 @@
     }
+    
+    if (this.props.scrollDisabled) {
+      noScroll.on();
+    }
   }
 
+  componentDidUpdate(prevProps) {
+    if (prevProps.scrollDisabled && !this.props.scrollDisabled) {
+      noScroll.off();
+    } else if (!prevProps.scrollDisabled && this.props.scrollDisabled) {
+      noScroll.on();
+    }
+  }
+
   componentWillUnmount() {
@@ -52,0 +60,0 @@ if (this.props.scrollDisabled) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

173821

increased by0.36%

Lines of code

411

increased by4.05%

No dependency changes