react-base-table - npm Package Compare versions

Comparing version 1.10.6 to 1.10.7

CHANGELOG.md

@@ -5,2 +5,6 @@ # CHANGELOG
 
+## v1.10.7 (2020-07-28)
+
+- fix: `getTotalRowsHeight` could be different before/after render in dynamic mode on initial render
+
 ## v1.10.6 (2020-07-25)
@@ -7,0 +11,0 @@

es/BaseTable.js

@@ -131,2 +131,4 @@ import _objectWithoutPropertiesLoose from "@babel/runtime/helpers/objectWithoutPropertiesLoose";
 
+      _this.forceUpdate();
+
       _this._isResetting = false;
@@ -871,4 +873,2 @@ }, 0);
   _proto.componentDidUpdate = function componentDidUpdate(prevProps, prevState) {
-    var _this2 = this;
-
     var _this$props13 = this.props,
@@ -892,10 +892,5 @@ data = _this$props13.data,
     if (estimatedRowHeight) {
-      // we have to wrap with setTimeout or we would still get the previous value,
-      // as we reset the inner components directly instead of update the table itself after row heights measured,
-      // so `componentDidUpdate` won't be invoked after that
-      setTimeout(function () {
-        if (_this2.getTotalRowsHeight() !== _this2._totalRowsHeight) {
-          _this2.forceUpdate();
-        }
-      });
+      if (this.getTotalRowsHeight() !== this._totalRowsHeight) {
+        this.forceUpdate();
+      }
     }
@@ -902,0 +897,0 @@ };

lib/BaseTable.js

@@ -171,2 +171,4 @@ "use strict";
 
+      _this.forceUpdate();
+
       _this._isResetting = false;
@@ -925,4 +927,2 @@ }, 0);
     value: function componentDidUpdate(prevProps, prevState) {
-      var _this2 = this;
-
       var _this$props13 = this.props,
@@ -946,10 +946,5 @@ data = _this$props13.data,
       if (estimatedRowHeight) {
-        // we have to wrap with setTimeout or we would still get the previous value,
-        // as we reset the inner components directly instead of update the table itself after row heights measured,
-        // so `componentDidUpdate` won't be invoked after that
-        setTimeout(function () {
-          if (_this2.getTotalRowsHeight() !== _this2._totalRowsHeight) {
-            _this2.forceUpdate();
-          }
-        });
+        if (this.getTotalRowsHeight() !== this._totalRowsHeight) {
+          this.forceUpdate();
+        }
       }
@@ -956,0 +951,0 @@ }

package.json

 {
   "name": "react-base-table",
-  "version": "1.10.6",
+  "version": "1.10.7",
   "description": "a react table component to display large data set with high performance and flexibility",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

897950

decreased by-0.14%

Lines of code

6825

decreased by-0.15%

No dependency changes