react-datalist-input - npm Package Compare versions

Comparing version 1.0.3 to 1.0.4

lib/DataListInput.js

@@ -115,4 +115,10 @@ import React from 'react';
     onSelect = (selectedItem) => {
-        if (selectedItem.key === this.state.lastValidItem.key) {
-            // do nothing onClick if key has not change since the last selection
+        if (this.state.lastValidItem !== undefined && selectedItem.key === this.state.lastValidItem.key){
+            // do not trigger the callback function
+            // but still change state to fit new selection
+            this.setState({
+                currentInput: selectedItem.label,
+                visible: false,
+                focusIndex: -1,
+            });
             return;
@@ -119,0 +125,0 @@ }

package.json

 {
   "name": "react-datalist-input",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "This package provides a react component as follows: an input field with a drop down menu to pick a possible option based on the current input.",
@@ -5,0 +5,0 @@ "main": "build/index.js",

src/index.js

@@ -122,4 +122,10 @@ import React from 'react';
     onSelect(selectedItem) {
-        if (selectedItem.key === this.state.lastValidItem.key) {
-            // do nothing onClick if key has not change since the last selection
+        if (this.state.lastValidItem !== undefined && selectedItem.key === this.state.lastValidItem.key){
+            // do not trigger the callback function
+            // but still change state to fit new selection
+            this.setState({
+                currentInput: selectedItem.label,
+                visible: false,
+                focusIndex: -1,
+            });
             return;
@@ -126,0 +132,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

89323

increased by0.82%

Lines of code

2164

increased by0.84%

No dependency changes