react-hotkeys-hook - npm Package Compare versions

Comparing version 4.0.0-3 to 4.0.0-4

package.json

 {
   "name": "react-hotkeys-hook",
-  "version": "4.0.0-3",
+  "version": "4.0.0-4",
   "repository": "https://[e-mail]/JohannesKlauss/react-keymap-hook.git",
@@ -5,0 +5,0 @@ "homepage": "https://johannesklauss.github.io/react-hotkeys-hook/",

src/parseHotkeys.ts

@@ -17,3 +17,4 @@ import { Hotkey, KeyboardModifiers, Keys } from './types'
     .split(combinationKey)
-    .map((k) => k.trim())
+    .map(k => k.trim())
+    .map(k => k === 'esc' ? 'escape' : k)
 
@@ -20,0 +21,0 @@ const modifiers: KeyboardModifiers = {

src/useHotkeys.ts

@@ -50,3 +50,3 @@ import { HotkeyCallback, Keys, OptionsOrDependencyArray, RefType } from './types'
 
-      // TODO: SINCE THE EVENT IS NOW ATTACHED TO THE REF THE ACTIVE ELEMENT CAN NEVER BE INSIDE THE REF. THE HOTKEY ONLY TRIGGERS IF THE
+      // TODO: SINCE THE EVENT IS NOW ATTACHED TO THE REF, THE ACTIVE ELEMENT CAN NEVER BE INSIDE THE REF. THE HOTKEY ONLY TRIGGERS IF THE
       // REF IS THE ACTIVE ELEMENT. THIS IS A PROBLEM SINCE FOCUSED SUB COMPONENTS WONT TRIGGER THE HOTKEY.
@@ -90,3 +90,8 @@
     const handleKeyUp = (event: KeyboardEvent) => {
-      pressedDownKeys.delete(event.key.toLowerCase())
+      if (event.key.toLowerCase() !== 'meta') {
+        pressedDownKeys.delete(event.key.toLowerCase())
+      } else {
+        // On macOS pressing down the meta key prevents triggering the keyup event for any other key https://stackoverflow.com/a/57153300/735226.
+        pressedDownKeys.clear()
+      }
 
@@ -93,0 +98,0 @@ if (memoisedOptions?.keyup) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

803816

increased by0.12%

Lines of code

766

increased by0.92%

No dependency changes