react-remove-scroll - npm Package Compare versions

Comparing version 2.5.4 to 2.5.5

dist/es2015/handleScroll.js

@@ -1,13 +0,15 @@
-var elementCouldBeVScrolled = function (node) {
-    var styles = window.getComputedStyle(node);
-    return (styles.overflowY !== 'hidden' && // not-not-scrollable
-        !(styles.overflowY === styles.overflowX && styles.overflowY === 'visible') // scrollable
-    );
+var alwaysContainsScroll = function (node) {
+    // textarea will always _contain_ scroll inside self. It only can be hidden
+    return node.tagName === 'TEXTAREA';
 };
-var elementCouldBeHScrolled = function (node) {
+var elementCanBeScrolled = function (node, overflow) {
     var styles = window.getComputedStyle(node);
-    return (styles.overflowX !== 'hidden' && // not-not-scrollable
-        !(styles.overflowY === styles.overflowX && styles.overflowX === 'visible') // scrollable
-    );
+    return (
+    // not-not-scrollable
+    styles[overflow] !== 'hidden' &&
+        // contains scroll inside self
+        !(styles.overflowY === styles.overflowX && !alwaysContainsScroll(node) && styles[overflow] === 'visible'));
 };
+var elementCouldBeVScrolled = function (node) { return elementCanBeScrolled(node, 'overflowY'); };
+var elementCouldBeHScrolled = function (node) { return elementCanBeScrolled(node, 'overflowX'); };
 export var locationCouldBeScrolled = function (axis, node) {
@@ -14,0 +16,0 @@ var current = node;

dist/es2015/SideEffect.js

@@ -89,3 +89,5 @@ import { __spreadArray } from "tslib";
         if (sourceEvent && sourceEvent.should) {
-            event.preventDefault();
+            if (event.cancelable) {
+                event.preventDefault();
+            }
             return;
@@ -101,3 +103,5 @@ }
             if (shouldStop) {
-                event.preventDefault();
+                if (event.cancelable) {
+                    event.preventDefault();
+                }
             }
@@ -104,0 +108,0 @@ }

dist/es2019/handleScroll.js

@@ -1,13 +0,14 @@
-const elementCouldBeVScrolled = (node) => {
+const alwaysContainsScroll = (node) => 
+// textarea will always _contain_ scroll inside self. It only can be hidden
+node.tagName === 'TEXTAREA';
+const elementCanBeScrolled = (node, overflow) => {
     const styles = window.getComputedStyle(node);
-    return (styles.overflowY !== 'hidden' && // not-not-scrollable
-        !(styles.overflowY === styles.overflowX && styles.overflowY === 'visible') // scrollable
-    );
+    return (
+    // not-not-scrollable
+    styles[overflow] !== 'hidden' &&
+        // contains scroll inside self
+        !(styles.overflowY === styles.overflowX && !alwaysContainsScroll(node) && styles[overflow] === 'visible'));
 };
-const elementCouldBeHScrolled = (node) => {
-    const styles = window.getComputedStyle(node);
-    return (styles.overflowX !== 'hidden' && // not-not-scrollable
-        !(styles.overflowY === styles.overflowX && styles.overflowX === 'visible') // scrollable
-    );
-};
+const elementCouldBeVScrolled = (node) => elementCanBeScrolled(node, 'overflowY');
+const elementCouldBeHScrolled = (node) => elementCanBeScrolled(node, 'overflowX');
 export const locationCouldBeScrolled = (axis, node) => {
@@ -14,0 +15,0 @@ let current = node;

dist/es2019/SideEffect.js

@@ -87,3 +87,5 @@ import * as React from 'react';
         if (sourceEvent && sourceEvent.should) {
-            event.preventDefault();
+            if (event.cancelable) {
+                event.preventDefault();
+            }
             return;
@@ -99,3 +101,5 @@ }
             if (shouldStop) {
-                event.preventDefault();
+                if (event.cancelable) {
+                    event.preventDefault();
+                }
             }
@@ -102,0 +106,0 @@ }

dist/es5/handleScroll.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.handleScroll = exports.locationCouldBeScrolled = void 0;
-var elementCouldBeVScrolled = function (node) {
-    var styles = window.getComputedStyle(node);
-    return (styles.overflowY !== 'hidden' && // not-not-scrollable
-        !(styles.overflowY === styles.overflowX && styles.overflowY === 'visible') // scrollable
-    );
+var alwaysContainsScroll = function (node) {
+    // textarea will always _contain_ scroll inside self. It only can be hidden
+    return node.tagName === 'TEXTAREA';
 };
-var elementCouldBeHScrolled = function (node) {
+var elementCanBeScrolled = function (node, overflow) {
     var styles = window.getComputedStyle(node);
-    return (styles.overflowX !== 'hidden' && // not-not-scrollable
-        !(styles.overflowY === styles.overflowX && styles.overflowX === 'visible') // scrollable
-    );
+    return (
+    // not-not-scrollable
+    styles[overflow] !== 'hidden' &&
+        // contains scroll inside self
+        !(styles.overflowY === styles.overflowX && !alwaysContainsScroll(node) && styles[overflow] === 'visible'));
 };
+var elementCouldBeVScrolled = function (node) { return elementCanBeScrolled(node, 'overflowY'); };
+var elementCouldBeHScrolled = function (node) { return elementCanBeScrolled(node, 'overflowX'); };
 var locationCouldBeScrolled = function (axis, node) {
@@ -17,0 +19,0 @@ var current = node;

dist/es5/SideEffect.js

@@ -94,3 +94,5 @@ "use strict";
         if (sourceEvent && sourceEvent.should) {
-            event.preventDefault();
+            if (event.cancelable) {
+                event.preventDefault();
+            }
             return;
@@ -106,3 +108,5 @@ }
             if (shouldStop) {
-                event.preventDefault();
+                if (event.cancelable) {
+                    event.preventDefault();
+                }
             }
@@ -109,0 +113,0 @@ }

package.json

 {
   "name": "react-remove-scroll",
-  "version": "2.5.4",
+  "version": "2.5.5",
   "description": "Disables scroll outside of `children` node.",
@@ -5,0 +5,0 @@ "main": "dist/es5/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

72525

increased by1.09%

Lines of code

1442

increased by1.19%

No dependency changes