react-sortable-hoc - npm Package Compare versions

Comparing version 0.4.2 to 0.4.3

CHANGELOG.md

 Changelog
 ------------
-### 0.4.1
-Fixes an issue when attempting to sort items while rapidly moving the mouse. By setting an immediate timer, we move the cancel event to the tail of the timer queue, and ensure that it is fired after the pressTimer [#80](https://github.com/clauderic/react-sortable-hoc/pull/80) Thanks @v0lkan!
+### 0.4.3
+Fixes an edge-case bug in Firefox where window.getComputedStyle() returns null inside an iframe with `display: none` [#106](https://github.com/clauderic/react-sortable-hoc/pull/106). Thanks [@funnel-mark](https://github.com/funnel-mark)!
 
+### 0.4.2
+Fixes an issue when attempting to sort items while rapidly moving the mouse. By setting an immediate timer, we move the cancel event to the tail of the timer queue, and ensure that it is fired after the pressTimer [#80](https://github.com/clauderic/react-sortable-hoc/pull/80). Thanks [@v0lkan](https://github.com/v0lkan)!
+
 ### 0.4.0
@@ -7,0 +10,0 @@ – Fix a timing issue in Chrome caused by setTimeout [#71](https://github.com/clauderic/react-sortable-hoc/pull/71)

dist/commonjs/utils.js

@@ -31,3 +31,7 @@ 'use strict';
     if (typeof window === 'undefined' || typeof document === 'undefined') return ''; // server environment
-    var styles = window.getComputedStyle(document.documentElement, '');
+    // fix for:
+    //    https://bugzilla.mozilla.org/show_bug.cgi?id=548397
+    //    window.getComputedStyle() returns null inside an iframe with display: none
+    // in this case return an array with a fake mozilla style in it.
+    var styles = window.getComputedStyle(document.documentElement, '') || ['-moz-hidden-iframe'];
     var pre = (Array.prototype.slice.call(styles).join('').match(/-(moz|webkit|ms)-/) || styles.OLink === '' && ['', 'o'])[1];
@@ -34,0 +38,0 @@

dist/es6/utils.js

@@ -21,3 +21,7 @@ export function arrayMove(arr, previousIndex, newIndex) {
     if (typeof window === 'undefined' || typeof document === 'undefined') return ''; // server environment
-    var styles = window.getComputedStyle(document.documentElement, '');
+    // fix for:
+    //    https://bugzilla.mozilla.org/show_bug.cgi?id=548397
+    //    window.getComputedStyle() returns null inside an iframe with display: none
+    // in this case return an array with a fake mozilla style in it.
+    var styles = window.getComputedStyle(document.documentElement, '') || ['-moz-hidden-iframe'];
     var pre = (Array.prototype.slice.call(styles).join('').match(/-(moz|webkit|ms)-/) || styles.OLink === '' && ['', 'o'])[1];
@@ -24,0 +28,0 @@

package.json

 {
   "name": "react-sortable-hoc",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Set of higher-order components to turn any list into a sortable, touch-friendly, animated list",
@@ -5,0 +5,0 @@ "author": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2974152

increased by0.05%

Lines of code

25362

increased by0.05%

No dependency changes