react-sortable-hoc - npm Package Compare versions

Comparing version 0.8.0 to 0.8.1

CHANGELOG.md

 Changelog
 ------------
+### 0.8.1
+- Fix scrolling issues on mobile with anchor tag elements [#380](https://github.com/clauderic/react-sortable-hoc/pull/380)
+- Update TypeScript type definition for ContainerGetter to accept Promises that return HTMLElements
+
 ### 0.8.0
@@ -4,0 +8,0 @@ - Allow `getContainer` to return a promise. This is useful when the container node is rendered by a parent component, since `componentDidMount` fires backwards (from child to parent) [#155](https://github.com/clauderic/react-sortable-hoc/pull/155/)

dist/commonjs/SortableContainer/index.js

@@ -94,3 +94,3 @@ 'use strict';
           */
-          if (event.target.tagName.toLowerCase() === 'a') {
+          if (!(0, _utils.isTouchEvent)(event) && event.target.tagName.toLowerCase() === 'a') {
             event.preventDefault();
@@ -97,0 +97,0 @@ }

dist/commonjs/utils.js

@@ -14,2 +14,3 @@ 'use strict';
 exports.getPosition = getPosition;
+exports.isTouchEvent = isTouchEvent;
 exports.getEdgeOffset = getEdgeOffset;
@@ -130,2 +131,6 @@ exports.getLockPixelOffset = getLockPixelOffset;
 
+function isTouchEvent(event) {
+  return event instanceof TouchEvent || event.touches && event.touches.length || event.changedTouches && event.changedTouches.length;
+}
+
 function getEdgeOffset(node, parent) {
@@ -132,0 +137,0 @@ var offset = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : { top: 0, left: 0 };

dist/es6/SortableContainer/index.js

@@ -16,3 +16,3 @@ import _extends from 'babel-runtime/helpers/extends';
 import Manager from '../Manager';
-import { closest, events, vendorPrefix, limit, getEdgeOffset, getElementMargin, getLockPixelOffset, getPosition, provideDisplayName, omit } from '../utils';
+import { closest, events, vendorPrefix, limit, getEdgeOffset, getElementMargin, getLockPixelOffset, getPosition, isTouchEvent, provideDisplayName, omit } from '../utils';
 
@@ -68,3 +68,3 @@ // Export Higher Order Sortable Container Component
           */
-          if (event.target.tagName.toLowerCase() === 'a') {
+          if (!isTouchEvent(event) && event.target.tagName.toLowerCase() === 'a') {
             event.preventDefault();
@@ -71,0 +71,0 @@ }

dist/es6/utils.js

@@ -110,2 +110,6 @@ import _Object$keys from 'babel-runtime/core-js/object/keys';
 
+export function isTouchEvent(event) {
+  return event instanceof TouchEvent || event.touches && event.touches.length || event.changedTouches && event.changedTouches.length;
+}
+
 export function getEdgeOffset(node, parent) {
@@ -112,0 +116,0 @@ var offset = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : { top: 0, left: 0 };

package.json

 {
   "name": "react-sortable-hoc",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Set of higher-order components to turn any list into a sortable, touch-friendly, animated list",
@@ -5,0 +5,0 @@ "author": {

types/index.d.ts

@@ -42,3 +42,3 @@ import * as React from 'react';
 
-export type ContainerGetter = (element: React.ReactElement<any>) => HTMLElement;
+export type ContainerGetter = (element: React.ReactElement<any>) => HTMLElement | Promise<HTMLElement>;
 
@@ -45,0 +45,0 @@ export interface Dimensions {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1083738

increased by0.17%

Lines of code

7194

increased by0.18%

No dependency changes