react-split-pane - npm Package Compare versions

Comparing version 0.1.83 to 0.1.84

dist/index.cjs.js

@@ -442,3 +442,8 @@ 'use strict';
       pane1Size: primary === 'first' ? initialSize : undefined,
-      pane2Size: primary === 'second' ? initialSize : undefined
+      pane2Size: primary === 'second' ? initialSize : undefined,
+
+      // these are props that are needed in static functions. ie: gDSFP
+      instanceProps: {
+        size: size
+      }
     };
@@ -454,3 +459,3 @@ return _this;
       document.addEventListener('touchmove', this.onTouchMove);
-      this.setState(SplitPane.setSize(this.props, this.state));
+      this.setState(SplitPane.getSizeUpdate(this.props, this.state));
     }
@@ -598,4 +603,3 @@ }, {
 
-    // TODO: find a more elegant way to fix this. memoize calls to setSize?
-    // we have to check values since gDSFP is called on every render
+    // we have to check values since gDSFP is called on every render and more in StrictMode
 
@@ -724,9 +728,15 @@ }, {
     value: function getDerivedStateFromProps(nextProps, prevState) {
-      return SplitPane.setSize(nextProps, prevState);
+      return SplitPane.getSizeUpdate(nextProps, prevState);
     }
   }, {
-    key: 'setSize',
-    value: function setSize(props, state) {
+    key: 'getSizeUpdate',
+    value: function getSizeUpdate(props, state) {
       var newState = {};
+      var instanceProps = state.instanceProps;
 
+
+      if (instanceProps.size === props.size && props.size !== undefined) {
+        return {};
+      }
+
       var newSize = props.size !== undefined ? props.size : getDefaultSize(props.defaultSize, props.minSize, props.maxSize, state.draggedSize);
@@ -743,2 +753,4 @@
 
+      newState.instanceProps = { size: props.size };
+
       return newState;
@@ -745,0 +757,0 @@ }

dist/index.esm.js

@@ -438,3 +438,8 @@ import React from 'react';
       pane1Size: primary === 'first' ? initialSize : undefined,
-      pane2Size: primary === 'second' ? initialSize : undefined
+      pane2Size: primary === 'second' ? initialSize : undefined,
+
+      // these are props that are needed in static functions. ie: gDSFP
+      instanceProps: {
+        size: size
+      }
     };
@@ -450,3 +455,3 @@ return _this;
       document.addEventListener('touchmove', this.onTouchMove);
-      this.setState(SplitPane.setSize(this.props, this.state));
+      this.setState(SplitPane.getSizeUpdate(this.props, this.state));
     }
@@ -594,4 +599,3 @@ }, {
 
-    // TODO: find a more elegant way to fix this. memoize calls to setSize?
-    // we have to check values since gDSFP is called on every render
+    // we have to check values since gDSFP is called on every render and more in StrictMode
 
@@ -720,9 +724,15 @@ }, {
     value: function getDerivedStateFromProps(nextProps, prevState) {
-      return SplitPane.setSize(nextProps, prevState);
+      return SplitPane.getSizeUpdate(nextProps, prevState);
     }
   }, {
-    key: 'setSize',
-    value: function setSize(props, state) {
+    key: 'getSizeUpdate',
+    value: function getSizeUpdate(props, state) {
       var newState = {};
+      var instanceProps = state.instanceProps;
 
+
+      if (instanceProps.size === props.size && props.size !== undefined) {
+        return {};
+      }
+
       var newSize = props.size !== undefined ? props.size : getDefaultSize(props.defaultSize, props.minSize, props.maxSize, state.draggedSize);
@@ -739,2 +749,4 @@
 
+      newState.instanceProps = { size: props.size };
+
       return newState;
@@ -741,0 +753,0 @@ }

index.d.ts

@@ -6,49 +6,51 @@ import * as Prefixer from 'inline-style-prefixer';
 
+type Partial<T> = { [P in keyof T]?: T[P] };
+
 export interface Props {
-    allowResize?: boolean;
-    className?: string;
-    primary?: 'first' | 'second';
-    minSize?: Size;
-    maxSize?: Size;
-    defaultSize?: Size;
-    size?: Size;
-    split?: 'vertical' | 'horizontal';
-    onDragStarted?: () => void;
-    onDragFinished?: (newSize: number) => void;
-    onChange?: (newSize: number) => void;
-    onResizerClick?: (event: MouseEvent) => void;
-    onResizerDoubleClick?: (event: MouseEvent) => void;
-    prefixer?: Prefixer;
-    style?: React.CSSProperties;
-    resizerStyle?: React.CSSProperties;
-    paneStyle?: React.CSSProperties;
-    pane1Style?: React.CSSProperties;
-    pane2Style?: React.CSSProperties;
-    resizerClassName?: string;
-    step?: number;
+  allowResize?: boolean;
+  className?: string;
+  primary?: 'first' | 'second';
+  minSize?: Size;
+  maxSize?: Size;
+  defaultSize?: Size;
+  size?: Size;
+  split?: 'vertical' | 'horizontal';
+  onDragStarted?: () => void;
+  onDragFinished?: (newSize: number) => void;
+  onChange?: (newSize: number) => void;
+  onResizerClick?: (event: MouseEvent) => void;
+  onResizerDoubleClick?: (event: MouseEvent) => void;
+  prefixer?: Prefixer;
+  style?: React.CSSProperties;
+  resizerStyle?: React.CSSProperties;
+  paneStyle?: React.CSSProperties;
+  pane1Style?: React.CSSProperties;
+  pane2Style?: React.CSSProperties;
+  resizerClassName?: string;
+  step?: number;
 }
 
 export interface State {
-    active: boolean;
-    resized: boolean;
+  active: boolean;
+  resized: boolean;
 }
 
 declare class SplitPane extends React.Component<Props, State> {
-    constructor();
+  constructor();
 
-    onMouseDown(event: MouseEvent): void;
-    
-    onTouchStart(event: TouchEvent): void;
+  onMouseDown(event: MouseEvent): void;
 
-    onMouseMove(event: MouseEvent): void;
+  onTouchStart(event: TouchEvent): void;
 
-    onTouchMove(event: TouchEvent): void;
+  onMouseMove(event: MouseEvent): void;
 
-    onMouseUp(): void;
+  onTouchMove(event: TouchEvent): void;
 
-    setSize(props: Props, state: State): void;
+  onMouseUp(): void;
 
-    static defaultProps: Props;
+  static getSizeUpdate(props: Props, state: State): Partial<State>;
+
+  static defaultProps: Props;
 }
 
 export default SplitPane;

package.json

@@ -12,3 +12,3 @@ {
   ],
-  "version": "0.1.83",
+  "version": "0.1.84",
   "repository": {
@@ -15,0 +15,0 @@ "type": "git",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

64989

increased by0.94%

Lines of code

1444

increased by1.19%

No dependency changes