recast - npm Package Compare versions

Comparing version 0.3.0 to 0.3.2

lib/parser.js

 var assert = require("assert"),
-    Syntax = require("./syntax"),
+    Syntax = require("./types").Syntax,
     Patcher = require("./patcher").Patcher,
@@ -4,0 +4,0 @@ Visitor = require("./visitor").Visitor,

lib/printer.js

 var assert = require("assert"),
-    Syntax = require("./syntax"),
+    Syntax = require("./types").Syntax,
     printComment = require("./comments").print,
@@ -305,2 +305,4 @@ linesModule = require("./lines"),
             } else {
+                if (i > 0)
+                    parts.push(" ");
                 parts.push(print(elem));
@@ -357,5 +359,12 @@ if (i < len - 1)
     case Syntax.NewExpression:
-        // Parenthesize the callee expression in case it's a function call.
-        var parts = ["new (", print(n.callee), ")"],
-            args = n.arguments;
+        var parts = [];
+
+        if (types.Identifier.check(n.callee)) {
+            parts.push("new ", print(n.callee));
+        } else {
+            // Parenthesize the callee expression in case it's a function call.
+            parts.push("new (", print(n.callee), ")");
+        }
+
+        var args = n.arguments;
         if (args)
@@ -407,2 +416,3 @@ parts.push(
     case Syntax.ForStatement:
+        // TODO Get the for (;;) case right.
         var init = print(n.init),
@@ -505,3 +515,3 @@ sep = init.length > 1 ? ";\n" : "; ",
     case Syntax.CatchClause:
-        var parts = [" catch(", print(n.param)];
+        var parts = [" catch (", print(n.param)];
 
@@ -624,2 +634,7 @@ if (n.guard)
     case Syntax.TemplateLiteral: // TODO
+    case Syntax.GeneratorExpression: // TODO
+    case Syntax.LetStatement: // TODO
+    case Syntax.LetExpression: // TODO
+    case Syntax.GraphExpression: // TODO
+    case Syntax.GraphIndexExpression: // TODO
     default:
@@ -626,0 +641,0 @@ debugger;

lib/types.js

@@ -13,1 +13,12 @@ var types = require("ast-types");
 exports.namedTypes = types.namedTypes;
+
+var Syntax = exports.Syntax = {};
+Object.keys(types.namedTypes).forEach(function(name) {
+    if (def(name).buildable)
+        Syntax[name] = name;
+});
+
+// These two types are buildable but do not technically count as syntax
+// because they are not printable.
+delete Syntax.SourceLocation;
+delete Syntax.Position;

lib/visitor.js

@@ -1,2 +0,2 @@
-var Syntax = require("./syntax"),
+var Syntax = require("./types").Syntax,
     Class = require("./Class").Class,
@@ -3,0 +3,0 @@ assert = require("assert"),

main.js

@@ -59,3 +59,3 @@ var fs = require("fs");
         enumerable: true,
-        value: require("./lib/syntax")
+        value: types.Syntax,
     },
@@ -62,0 +62,0 @@

package.json

@@ -15,3 +15,3 @@ {
   ],
-  "version": "0.3.0",
+  "version": "0.3.2",
   "homepage": "http://github.com/benjamn/recast",
@@ -29,3 +29,3 @@ "repository": {
     "private": ">= 0.0.3",
-    "ast-types": ">= 0.2.6"
+    "ast-types": ">= 0.2.8"
   },
@@ -32,0 +32,0 @@ "devDependencies": {},

test/parser.js

@@ -5,3 +5,3 @@ var assert = require("assert"),
     Visitor = require("../lib/visitor").Visitor,
-    Syntax = require("../lib/syntax"),
+    Syntax = require("../lib/types").Syntax,
     printComment = require("../lib/comments").print,
@@ -8,0 +8,0 @@ fromString = require("../lib/lines").fromString;

test/syntax.js

 var assert = require("assert");
 var fs = require("fs");
 var path = require("path");
-var Syntax = require("../lib/syntax");
+var Syntax = require("../lib/types").Syntax;
 var Parser = require("../lib/parser").Parser;
@@ -31,6 +31,2 @@ var Visitor = require("../lib/visitor").Visitor;
 
-        for (name in types) {
-            assert.fail(name, "not found in Syntax");
-        }
-
         t.finish();
@@ -37,0 +33,0 @@ });

test/visitor.js

 var Visitor = require("../lib/visitor").Visitor,
-    Syntax = require("../lib/syntax"),
+    Syntax = require("../lib/types").Syntax,
     Parser = require("../lib/parser").Parser,
@@ -4,0 +4,0 @@ Printer = require("../lib/printer").Printer;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

357422

increased by0.01%

Worsened metrics

Number of package files

30

decreased by-3.23%

Lines of code

10604

decreased by-0.01%

Dependency changes

• Updatedast-types@>= 0.2.8