redact-url - npm Package Compare versions

Comparing version 0.3.1 to 0.4.0

index.js

 var isURL = require("is-url")
 var URL = require("url")
 var qs = require("querystring")
+var urlRegex = require("url-regex")
 
@@ -9,5 +10,13 @@ var redact = module.exports = function(input, replacement) {
 
+  var isUrlWithPort = function(val) {
+    if (isURL(val)) return true;
+    if (urlRegex({strict: true, exact: true}).test(val)) return true;
+    if (val.match(/^git\+(https?|ssl)/) && urlRegex({strict: true, exact: false}).test(val)) return true;
+
+    return false;
+  }
+
   // Require a URL or git+protocol URL-esque string
   // https://www.npmjs.org/doc/json.html#Git-URLs-as-Dependencies
-  if (!isURL(input) && !input.match(/^git\+(https?|ssh)/)) return input
+  if (!isUrlWithPort(input)) return input
 
@@ -14,0 +23,0 @@ var url = URL.parse(input)

package.json

 {
   "name": "redact-url",
-  "version": "0.3.1",
+  "version": "0.4.0",
   "description": "Redact or remove authentication data from URLs",
@@ -28,7 +28,8 @@ "main": "index.js",
   "devDependencies": {
-    "mocha": "^1.19.0"
+    "mocha": "^5.2.0"
   },
   "dependencies": {
-    "is-url": "^1.1.0"
+    "is-url": "^1.1.0",
+    "url-regex": "^4.1.1"
   }
 }

test/index.js

@@ -1,3 +0,1 @@
-"use strict";
-
 var mocha = require("mocha")
@@ -32,7 +30,14 @@ var assert = require("assert")
 
-  it("supports git+ssh URLs", function() {
-    assert.equal(redact("git+ssh://zeke:[e-mail]/zeke/outlet", ""), "git+ssh://github.com/zeke/outlet")
-    assert.equal(redact("git+ssh://zeke:[e-mail]/zeke/outlet", ""), "git+ssh://github.com/zeke/outlet")
+  it("supports git+ssl URLs", function() {
+    assert.equal(redact("git+ssl://zeke:[e-mail]/zeke/outlet", ""), "git+ssl://github.com/zeke/outlet")
   })
 
+  it("supports URLs with ports", function() {
+    assert.equal(redact("http://zeke:[e-mail]:1234/zeke/outlet"), "http://[e-mail]:1234/zeke/outlet")
+  });
+
+  it("supports URLs unusual protocols", function() {
+    assert.equal(redact("amqp://zeke:[e-mail]:1234/zeke/outlet"), "amqp://[e-mail]:1234/zeke/outlet")
+  });
+
   describe("redacts query parameters with secret-sounding names", function() {
@@ -39,0 +44,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6549

increased by33.98%

Lines of code

74

increased by17.46%

Worsened metrics

Dependency count

2

increased by100%

Dependency changes

• + Addedurl-regex@^4.1.1

• + Addedip-regex@1.0.3(transitive)

• + Addedtlds@1.255.0(transitive)

• + Addedurl-regex@4.1.1(transitive)