remote.it - npm Package Compare versions

Comparing version 0.43.2 to 0.44.0

lib/remote.it.d.ts

@@ -42,10 +42,9 @@ import { AxiosError, Method } from 'axios'
      */
-    parseServiceType(
+    parseDeviceType(
       rawType: string
-    ):
-      | ServiceType
-      | {
-          id: undefined
-          name: string
-        }
+    ): {
+      id: number
+      port: number
+      name: string
+    }
     all(): Promise<IDevice[]>
@@ -410,2 +409,3 @@ metadata(): Promise<IRawMetaData>
   typeID?: number
+  port?: number
 }
@@ -412,0 +412,0 @@ export interface IRawDevice {

lib/remote.it.js

@@ -333,10 +333,13 @@ "use strict";
              */
-            parseServiceType: function (rawType) {
+            parseDeviceType: function (rawType) {
                 var pairs = rawType.split(':');
                 var typeHex = '0x' + pairs[0] + pairs[1];
+                var portHex = '0x' + pairs[10] + pairs[11];
                 var id = utils_1.toNumber(typeHex, 16);
-                return (r3.devices.serviceTypes.find(function (t) { return t.id === id; }) || {
-                    id: undefined,
-                    name: 'Unknown Service',
-                });
+                var serviceType = r3.devices.serviceTypes.find(function (t) { return t.id === id; });
+                return {
+                    id: id,
+                    port: utils_1.toNumber(portHex, 16),
+                    name: serviceType ? serviceType.name : 'Unknown Service',
+                };
             },
@@ -604,2 +607,3 @@ all: function () {
                             name: s.devicealias,
+                            port: r3.devices.parseDeviceType(s.devicetype).port,
                             state: s.devicestate,
@@ -611,4 +615,4 @@ protocol: s.servicetitle,
                             region: s.georegion,
-                            type: r3.devices.parseServiceType(s.devicetype).name,
-                            typeID: r3.devices.parseServiceType(s.devicetype).id,
+                            type: r3.devices.parseDeviceType(s.devicetype).name,
+                            typeID: r3.devices.parseDeviceType(s.devicetype).id,
                             deviceID: device
@@ -615,0 +619,0 @@ ? device.deviceaddress

package.json

 {
   "name": "remote.it",
-  "version": "0.43.2",
+  "version": "0.44.0",
   "description": "remote.it JavaScript/node client library",
@@ -5,0 +5,0 @@ "main": "lib/remote.it.js",

src/remote.it.ts

@@ -237,12 +237,13 @@ import axios, { AxiosError, AxiosResponse, Method } from 'axios'
        */
-      parseServiceType(rawType: string) {
+      parseDeviceType(rawType: string) {
         const pairs = rawType.split(':')
         const typeHex = '0x' + pairs[0] + pairs[1]
+        const portHex = '0x' + pairs[10] + pairs[11]
         const id = toNumber(typeHex, 16)
-        return (
-          r3.devices.serviceTypes.find(t => t.id === id) || {
-            id: undefined,
-            name: 'Unknown Service',
-          }
-        )
+        const serviceType = r3.devices.serviceTypes.find(t => t.id === id)
+        return {
+          id,
+          port: toNumber(portHex, 16),
+          name: serviceType ? serviceType.name : 'Unknown Service',
+        }
       },
@@ -474,2 +475,3 @@ async all(): Promise<IDevice[]> {
                       name: s.devicealias,
+                      port: r3.devices.parseDeviceType(s.devicetype).port,
                       state: s.devicestate as ServiceState,
@@ -481,4 +483,4 @@ protocol: s.servicetitle,
                       region: s.georegion,
-                      type: r3.devices.parseServiceType(s.devicetype).name,
-                      typeID: r3.devices.parseServiceType(s.devicetype).id,
+                      type: r3.devices.parseDeviceType(s.devicetype).name,
+                      typeID: r3.devices.parseDeviceType(s.devicetype).id,
                       deviceID: device
@@ -1205,2 +1207,3 @@ ? device.deviceaddress
   typeID?: number
+  port?: number
 }
@@ -1207,0 +1210,0 @@

test/data.ts

@@ -18,3 +18,3 @@ export const rawDevices = {
       localurl: 'bm9uZQ==',
-      ownerusername: '[e-mail]',
+      ownerusername: '[e-mail]',
       servicetitle: 'Bulk Service',
@@ -35,3 +35,3 @@ shared: 'shared-from',
       localurl: 'bm9uZQ==',
-      ownerusername: '[e-mail]',
+      ownerusername: '[e-mail]',
       servicetitle: 'Generic TCP',
@@ -145,3 +145,3 @@ shared: 'shared-from',
       localurl: 'aHR0cDovL25vbmUvL2dlbmVyaWMvaW5kZXgucGhw',
-      ownerusername: '[e-mail]',
+      ownerusername: '[e-mail]',
       servicetitle: 'Generic TCP',
@@ -148,0 +148,0 @@ shared: 'shared-from',

test/remote.it.test.ts

@@ -611,3 +611,3 @@ import setup, {
             name: 'owencraft',
-            owner: '[e-mail]',
+            owner: '[e-mail]',
             region: 'NorthAmerica',
@@ -645,2 +645,3 @@ services: [],
                 deviceID: '80:00:00:05:46:03:47:2B',
+                port: 22,
               },
@@ -659,2 +660,3 @@ {
                 deviceID: '80:00:00:05:46:03:47:2B',
+                port: 80,
               },
@@ -689,2 +691,3 @@ ],
                 deviceID: '80:00:00:05:46:03:48:4A',
+                port: 22,
               },
@@ -691,0 +694,0 @@ ],

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

178128

increased by0.44%

Lines of code

4077

increased by0.25%

No dependency changes