retry-request - npm Package Compare versions

Comparing version 1.1.1 to 1.2.0

index.js

@@ -44,2 +44,3 @@ 'use strict';
     retryStream = through();
+    retryStream.abort = resetStreams;
   }
@@ -55,4 +56,7 @@
     cacheStream = null;
-    requestStream.abort();
-    requestStream.destroy();
+
+    if (requestStream) {
+      requestStream.abort();
+      requestStream.destroy();
+    }
   }
@@ -67,3 +71,3 @@
 
-      streamForward(requestStream)
+      streamForward(requestStream, { events: ['response', 'complete'] })
         .on('error', onResponse)
@@ -103,4 +107,4 @@ .on('response', onResponse.bind(null, null))
       streamForward(cacheStream)
-        .on('error', resetStreams)
-        .pipe(retryStream);
+        .pipe(retryStream)
+        .on('error', resetStreams);
     } else {
@@ -107,0 +111,0 @@ callback(err, response, body);

package.json

 {
   "name": "retry-request",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "description": "Retry a request.",
@@ -5,0 +5,0 @@ "main": "index.js",

readme.md

@@ -1,7 +0,5 @@
-# retry-request
+|![retry-request](logo.png)
+|:-:
+|Retry a [request][request] with built-in [exponential backoff](https://developers.google.com/analytics/devguides/reporting/core/v3/coreErrors#backoff).
 
-> Retry a [request][request] with built-in [exponential backoff](https://developers.google.com/analytics/devguides/reporting/core/v3/coreErrors#backoff).
-
-## Use
-
 ```sh
@@ -11,3 +9,3 @@ $ npm install --save retry-request
 ```js
-var retryRequest = require('retry-request');
+var request = require('retry-request');
 ```
@@ -21,6 +19,6 @@
 
-`urlThatReturns404` will be requested 3 total times before giving up and executing the callback.
+`urlThatReturns503` will be requested 3 total times before giving up and executing the callback.
 
 ```js
-retryRequest(urlThatReturns404, function (err, resp, body) {});
+request(urlThatReturns503, function (err, resp, body) {});
 ```
@@ -30,6 +28,6 @@
 
-`urlThatReturns404` will be requested 3 total times before giving up and emitting the `response` and `complete` event as usual.
+`urlThatReturns503` will be requested 3 total times before giving up and emitting the `response` and `complete` event as usual.
 
 ```js
-retryRequest(urlThatReturns404)
+request(urlThatReturns503)
   .on('error', function () {})
@@ -40,3 +38,3 @@ .on('response', function () {})
 
-## retryRequest(requestOptions, [opts], [cb])
+## request(requestOptions, [opts], [cb])
 
@@ -60,4 +58,4 @@ ### requestOptions
 
-retryRequest(urlThatReturns404, opts, function (err, resp, body) {
-  // urlThatReturns404 was requested a total of 5 times
+request(urlThatReturns503, opts, function (err, resp, body) {
+  // urlThatReturns503 was requested a total of 5 times
   // before giving up and executing this callback.
@@ -80,3 +78,3 @@ });
 
-retryRequest(urlThatReturnsNonOKStatusMessage, opts, function (err, resp, body) {
+request(urlThatReturnsNonOKStatusMessage, opts, function (err, resp, body) {
   // urlThatReturnsNonOKStatusMessage was requested a
@@ -96,3 +94,3 @@ // total of 3 times, each time using `opts.shouldRetryFn`
 ```js
-var request = require('request').defaults({
+var originalRequest = require('request').defaults({
   pool: {
@@ -104,7 +102,7 @@ maxSockets: Infinity
 var opts = {
-  request: request
+  request: originalRequest
 };
 
-retryRequest(urlThatReturns404, opts, function (err, resp, body) {
-  // Your provided `request` instance was used.
+request(urlThatReturns503, opts, function (err, resp, body) {
+  // Your provided `originalRequest` instance was used.
 });
@@ -111,0 +109,0 @@ ```

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6894

increased by1.59%

Lines of code

94

increased by3.3%

Worsened metrics

Number of lines in readme file

108

decreased by-1.82%

No dependency changes