rheactor-value-objects - npm Package Compare versions

Comparing version 8.2.0 to 9.0.0

dist/domain.js

@@ -37,2 +37,3 @@ 'use strict';
     }
+    domain = domain.toLowerCase();
     if (!domainRegex.test(domain)) {
@@ -39,0 +40,0 @@ throw new _rheactorErrors.ValidationFailedError('Not a domain: ' + domain);

dist/email.js

@@ -16,3 +16,3 @@ 'use strict';
 
-var emailRegex = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
+var emailRegex = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-z\-0-9]+\.)+[a-z]{2,}))$/;
 
@@ -36,3 +36,2 @@ var EmailValue = exports.EmailValue = function () {
     email = email.toLowerCase();
-    // http://emailregex.com/
     if (!emailRegex.test(email)) {
@@ -39,0 +38,0 @@ throw new _rheactorErrors.ValidationFailedError('Not an email: ' + email);

package.json

 {
   "name": "rheactor-value-objects",
   "description": "A collection of value objects",
-  "version": "8.2.0",
+  "version": "9.0.0",
   "main": "dist/index.js",
@@ -6,0 +6,0 @@ "scripts": {

src/domain.js

@@ -23,2 +23,3 @@ import {ValidationFailedError} from '@resourcefulhumans/rheactor-errors'
     }
+    domain = domain.toLowerCase()
     if (!domainRegex.test(domain)) {
@@ -25,0 +26,0 @@ throw new ValidationFailedError('Not a domain: ' + domain)

src/email.js

 import {ValidationFailedError} from '@resourcefulhumans/rheactor-errors'
 import {String as StringType, irreducible, maybe} from 'tcomb'
 
-const emailRegex = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/
+const emailRegex = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-z\-0-9]+\.)+[a-z]{2,}))$/
 
@@ -21,3 +21,2 @@ export class EmailValue {
     email = email.toLowerCase()
-    // http://emailregex.com/
     if (!emailRegex.test(email)) {
@@ -24,0 +23,0 @@ throw new ValidationFailedError('Not an email: ' + email)

test/domain.spec.js

@@ -13,2 +13,3 @@ import {DomainValue, DomainValueType, MaybeDomainValueType} from '../src'
         'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijk.com', // 63 chars
+        'staRHs.example', // case-insensitive
         'rh.com', // two letter
@@ -21,3 +22,3 @@ 'r.com', // one letter
         let d = new DomainValue(domain)
-        expect(d.toString()).to.equal(domain)
+        expect(d.toString()).to.equal(domain.toLowerCase())
       })
@@ -66,6 +67,9 @@ })
   describe('.equals()', () => {
-    it('should return true for the same emails', () => {
+    it('should return true for the same domains', () => {
       expect(new DomainValue('resourceful-humans.com').equals(new DomainValue('resourceful-humans.com'))).to.equal(true)
     })
-    it('should return false for different emails', () => {
+    it('should return true for the same domains (acse-insensitive)', () => {
+      expect(new DomainValue('staRHs.example').equals(new DomainValue('starhs.example'))).to.equal(true)
+    })
+    it('should return false for different domains', () => {
       expect(new DomainValue('resourceful-humans.com').equals(new DomainValue('resourceful-humans.de'))).to.equal(false)
@@ -72,0 +76,0 @@ })

test/email.spec.js

@@ -14,6 +14,7 @@ import {EmailValue, EmailValueType, MaybeEmailValueType} from '../src'
         '[e-mail]',
+        '[e-mail]',
         '[e-mail]'
       ].map(email => {
         let d = new EmailValue(email)
-        expect(d.toString()).to.equal(email)
+        expect(d.toString()).to.equal(email.toLowerCase())
       })
@@ -62,2 +63,5 @@ })
     })
+    it('should return true for the same emails (case insensitive)', () => {
+      expect(new EmailValue('[e-mail]').equals(new EmailValue('[e-mail]'))).to.equal(true)
+    })
     it('should return false for different emails', () => {
@@ -64,0 +68,0 @@ expect(new EmailValue('[e-mail]').equals(new EmailValue('[e-mail]'))).to.equal(false)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

57507

increased by0.91%

Lines of code

1615

increased by0.5%

No dependency changes