riot-observable - npm Package Compare versions

Comparing version 2.3.0 to 2.3.1-beta

dist/observable.js

@@ -75,12 +75,3 @@ ;(function(window, undefined) {var observable = function(el) {
       el.off(events, on)
-
-      // V8 performance optimization
-      // https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-      var arglen = arguments.length
-      var args = new Array(arglen)
-      for (var i = 0; i < arglen; i++) {
-        args[i] = arguments[i]
-      }
-
-      fn.apply(el, args)
+      fn.apply(el, arguments)
     }
@@ -97,8 +88,9 @@ return el.on(events, on)
   defineProperty('trigger', function(events) {
-    // V8 performance optimization
-    // https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-    var arglen = arguments.length - 1
-    var args = new Array(arglen)
+
+    // getting the arguments
+    // skipping the first one
+    var arglen = arguments.length - 1,
+      args = new Array(arglen)
     for (var i = 0; i < arglen; i++) {
-      args[i] = arguments[i + 1] // skip first argument
+      args[i] = arguments[i + 1]
     }
@@ -105,0 +97,0 @@

dist/riot.observable.js

@@ -75,12 +75,3 @@ riot.observable = function(el) {
       el.off(events, on)
-
-      // V8 performance optimization
-      // https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-      var arglen = arguments.length
-      var args = new Array(arglen)
-      for (var i = 0; i < arglen; i++) {
-        args[i] = arguments[i]
-      }
-
-      fn.apply(el, args)
+      fn.apply(el, arguments)
     }
@@ -97,8 +88,9 @@ return el.on(events, on)
   defineProperty('trigger', function(events) {
-    // V8 performance optimization
-    // https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-    var arglen = arguments.length - 1
-    var args = new Array(arglen)
+
+    // getting the arguments
+    // skipping the first one
+    var arglen = arguments.length - 1,
+      args = new Array(arglen)
     for (var i = 0; i < arglen; i++) {
-      args[i] = arguments[i + 1] // skip first argument
+      args[i] = arguments[i + 1]
     }
@@ -105,0 +97,0 @@

lib/index.js

@@ -75,12 +75,3 @@ var observable = function(el) {
       el.off(events, on)
-
-      // V8 performance optimization
-      // https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-      var arglen = arguments.length
-      var args = new Array(arglen)
-      for (var i = 0; i < arglen; i++) {
-        args[i] = arguments[i]
-      }
-
-      fn.apply(el, args)
+      fn.apply(el, arguments)
     }
@@ -97,8 +88,9 @@ return el.on(events, on)
   defineProperty('trigger', function(events) {
-    // V8 performance optimization
-    // https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#3-managing-arguments
-    var arglen = arguments.length - 1
-    var args = new Array(arglen)
+
+    // getting the arguments
+    // skipping the first one
+    var arglen = arguments.length - 1,
+      args = new Array(arglen)
     for (var i = 0; i < arglen; i++) {
-      args[i] = arguments[i + 1] // skip first argument
+      args[i] = arguments[i + 1]
     }
@@ -105,0 +97,0 @@

package.json

 {
   "name": "riot-observable",
-  "version": "2.3.0",
+  "version": "2.3.1-beta",
   "description": "Simple script to send and receive events",
@@ -5,0 +5,0 @@ "main": "dist/observable.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

45528

increased by4.45%

Number of package files

21

increased by5%

Lines of code

707

increased by12.22%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes