Comparing version 0.5.7 to 0.5.8
# Change Log | ||
**0.5.8** | ||
- Fix bug that caused some frames to not report context lines. See [#52](https://github.com/rollbar/node_rollbar/pull/52) | ||
**0.5.7** | ||
@@ -4,0 +7,0 @@ - Fix bug fetching request protocol. See [#56](https://github.com/rollbar/node_rollbar/pull/56) |
@@ -226,3 +226,3 @@ /*jslint devel: true, nomen: true, plusplus: true, regexp: true, indent: 2, maxlen: 100 */ | ||
function gatherContextLines(frame, callback) { | ||
var lines = tempFileCache[frame.filename]; | ||
var lines = tempFileCache[frame.filename] || cache.get(frame.filename); | ||
@@ -229,0 +229,0 @@ if (lines) { |
@@ -13,3 +13,3 @@ { | ||
], | ||
"version": "0.5.7", | ||
"version": "0.5.8", | ||
"repository": "git://github.com/rollbar/node_rollbar.git", | ||
@@ -16,0 +16,0 @@ "author": "Rollbar, Inc. <support@rollbar.com>", |
@@ -134,3 +134,6 @@ /*jslint devel: true, nomen: true, plusplus: true, regexp: true, unparam: true, indent: 2, maxlen: 100 */ | ||
topic: function (err, exc) { | ||
return parser.parseException(exc, this.callback); | ||
var self = this; | ||
return parser.parseException(exc, function(err, parsedObj) { | ||
self.callback(err, parsedObj, exc); | ||
}); | ||
}, | ||
@@ -150,2 +153,12 @@ 'verify the filename': function (err, parsedObj) { | ||
assert.includes(lastFrame.code, 'new Error(\'Hello World\')'); | ||
}, | ||
'parse the same error again': { | ||
topic: function(err, parsedObj, exc) { | ||
return parser.parseException(exc, this.callback); | ||
}, | ||
'verify the context line again': function (err, parsedObj) { | ||
var lastFrame = parsedObj.frames[parsedObj.frames.length - 1]; | ||
assert.isString(lastFrame.code); | ||
assert.includes(lastFrame.code, 'new Error(\'Hello World\')'); | ||
} | ||
} | ||
@@ -152,0 +165,0 @@ } |
# Contributors | ||
Huge thanks to the following contributors (by github username). For the most up-to-date list, see https://github.com/rollbar/rollbar-gem/graphs/contributors | ||
Huge thanks to the following contributors (by github username). For the most up-to-date list, see https://github.com/rollbar/node_rollbar/graphs/contributors | ||
@@ -11,1 +11,2 @@ - [calvinalvin](https://github.com/calvinalvin) | ||
- [thomblake](https://github.com/thomblake) | ||
- [bjyoungblood](https://github.com/bjyoungblood) |
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
65929
1503