rss-parser - npm Package Compare versions

Comparing version 2.2.2 to 2.2.4

index.js

@@ -40,19 +40,23 @@ var Entities = require("entities");
   var json = {feed: {entries: []}};
-  if (feed.link[0] && feed.link[0].$.href) {
-    json.feed.link = feed.link[0].$.href;
+  if (feed.link) {
+    if (feed.link[0] && feed.link[0].$.href) json.feed.link = feed.link[0].$.href;
+    if (feed.link[1] && feed.link[1].$.href) json.feed.feedUrl = feed.link[1].$.href;
   }
-  if (feed.link[1] && feed.link[1].$.href) {
-    json.feed.feedUrl = feed.link[1].$.href;
+  if (feed.title) {
+    var title = feed.title[0] || '';
+    if (title._) title = title._
+    if (title) json.feed.title = title;
   }
-  if (feed.title[0]) {
-    json.feed.title = feed.title[0];
-  }
   var entries = feed.entry;
   (entries || []).forEach(function (entry) {
     var item = {};
-    if (entry.title) item.title = entry.title[0];
-    if (entry.link) item.link = entry.link[0].$.href;
-    if (entry.updated) item.pubDate = new Date(entry.updated[0]).toISOString();
-    if (entry.author) item.author = entry.author[0].name[0];
-    if (entry.content) {
+    if (entry.title) {
+      var title = entry.title[0] || '';
+      if (title._) title = title._;
+      if (title) item.title = title;
+    }
+    if (entry.link && entry.link.length) item.link = entry.link[0].$.href;
+    if (entry.updated && entry.updated.length) item.pubDate = new Date(entry.updated[0]).toISOString();
+    if (entry.author && entry.author.length) item.author = entry.author[0].name[0];
+    if (entry.content && entry.content.length) {
       item.content = getContent(entry.content[0]);
@@ -59,0 +63,0 @@ item.contentSnippet = getSnippet(item.content)

package.json

 {
   "name": "rss-parser",
-  "version": "2.2.2",
+  "version": "2.2.4",
   "main": "index.js",
@@ -5,0 +5,0 @@ "scripts": {

test/parser.js

@@ -32,5 +32,5 @@ var FS = require('fs');
 
-  it('should parse craigslist', function(done) {
-    Parser.parseURL('https://seattle.craigslist.org/search/act?format=rss', function(err, parsed) {
-      Expect(err).to.not.equal(null);
+  it('should not parse craigslist (RSS 1.0)', function(done) {
+    Parser.parseFile(__dirname + '/input/craigslist.rss', function(err, parsed) {
+      Expect(err.indexOf('not yet implemented')).to.not.equal(-1);
       done();
@@ -51,2 +51,10 @@ })
   })
+
+  it('should parse with missing fields', function(done) {
+    testParseForFile('missing-fields', 'atom', done)
+  })
+
+  it('should parse heise', function(done) {
+    testParseForFile('heise', 'atom', done);
+  })
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

750505

increased by5.8%

Number of package files

21

increased by23.53%

Lines of code

14138

increased by1.23%

No dependency changes