selenium-standalone - npm Package Compare versions

Comparing version 2.41.0-2.9.0-1 to 2.42.0-2.9.0

conf.js

 var path = require('path');
 
 // see http://selenium-release.storage.googleapis.com/index.html for latest
-var version = '2.41.0';
+var version = '2.42.0';
 
@@ -6,0 +6,0 @@ module.exports = {

index.js

 var spawn = require('child_process').spawn;
-var conf = require('./conf.js');
+var conf = require( './conf.js' );
+var async = require( 'async' );
+var whereis = require( 'whereis' );
 
@@ -14,4 +16,2 @@ module.exports = standalone;
 function standalone(spawnOptions, seleniumArgs) {
-  process.on('SIGTERM', kill);
-
   spawnOptions = spawnOptions || { stdio: 'inherit' };
@@ -28,3 +28,8 @@ seleniumArgs = seleniumArgs || [];
 
+  ['exit', 'SIGTERM', 'SIGINT'].forEach(function listenAndKill(evName) {
+    process.on(evName, kill);
+  });
+
   function kill() {
+    // we may not have started the selenium process at this stage
     if (selenium) {
@@ -31,0 +36,0 @@ selenium.kill('SIGTERM');

package.json

 {
   "name": "selenium-standalone",
-  "version": "2.41.0-2.9.0-1",
+  "version": "2.42.0-2.9.0",
   "description": "installs a `start-selenium` command line to start a standalone selenium server with chrome-driver",
@@ -8,3 +8,3 @@ "main": "index.js",
     "install": "node install.js",
-    "test": "mocha test.js -R tap | faucet"
+    "test": "mocha"
   },
@@ -28,8 +28,8 @@ "bin": {
     "rimraf": "^2.2.8",
-    "unzip": "^0.1.9"
+    "unzip": "^0.1.9",
+    "whereis": "0.2.1"
   },
   "devDependencies": {
-    "mocha": "^1.19.0",
-    "faucet": "^0.0.1"
+    "mocha": "^1.19.0"
   }
 }

README.md

@@ -9,3 +9,3 @@ # selenium-standalone
 
-Currently installs selenium `2.41.0` and chrome driver `2.9`.
+Currently installs selenium `2.42.0` and chrome driver `2.9`.
 
@@ -65,3 +65,3 @@ ```shell
 
-// spawnOptions defaults to `{ stdio: 'pipe' }`
+// spawnOptions defaults to `{ stdio: 'inherit' }`
 // seleniumArgs defaults to `[]`
@@ -68,0 +68,0 @@

test.js

 describe('programmatic use', function () {
   it('should start', function(done) {
     this.timeout(20000);
+    var timedout;
     var selenium = require('./index.js');
@@ -11,2 +12,3 @@ var proc = selenium.start({ stdio: 'pipe' });
         proc.kill();
+        clearTimeout(timedout);
         done();
@@ -16,3 +18,3 @@ }
 
-    setTimeout(function() {
+    timedout = setTimeout(function() {
       proc.kill();
@@ -19,0 +21,0 @@ done(new Error('Server never started'));

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

9650

increased by4.7%

Dev dependency count

1

decreased by-50%

Lines of code

171

increased by4.27%

Worsened metrics

Dependency count

5

increased by25%

Dependency changes

• + Addedwhereis@0.2.1

• + Addedwhereis@0.2.1(transitive)