selfsigned - npm Package Compare versions

Comparing version 3.0.1 to 4.0.0

.claude/settings.local.json

+{
+  "permissions": {
+    "allow": [
+      "Bash(npm test)"
+    ],
+    "deny": [],
+    "ask": []
+  }
+}

index.js

@@ -21,2 +21,6 @@ var forge = require("node-forge");
       return forge.md.sha256.create();
+    case 'sha384':
+      return forge.md.sha384.create();
+    case 'sha512':
+      return forge.md.sha512.create();
     default:
@@ -32,3 +36,3 @@ return forge.md.sha1.create();
  * @param {number} [options.days=365] the number of days before expiration
- * @param {number} [options.keySize=1024] the size for the private key in bits
+ * @param {number} [options.keySize=2048] the size for the private key in bits
  * @param {object} [options.extensions] additional extensions for the certificate
@@ -149,3 +153,3 @@ * @param {string} [options.algorithm="sha1"] The signature algorithm sha256 or sha1
       var clientkeys = forge.pki.rsa.generateKeyPair(
-        options.clientCertificateKeySize || 1024
+        options.clientCertificateKeySize || 2048
       );
@@ -184,3 +188,3 @@ var clientcert = forge.pki.createCertificate();
       // Sign client cert with root cert
-      clientcert.sign(keyPair.privateKey);
+      clientcert.sign(keyPair.privateKey, getAlgorithm(options && options.algorithm));
 
@@ -219,3 +223,3 @@ pem.clientprivate = forge.pki.privateKeyToPem(clientkeys.privateKey);
 
-  var keySize = options.keySize || 1024;
+  var keySize = options.keySize || 2048;
 
@@ -222,0 +226,0 @@ if (done) {

package.json

 {
   "name": "selfsigned",
-  "version": "3.0.1",
+  "version": "4.0.0",
   "description": "Generate self signed certificates private and public keys",
@@ -5,0 +5,0 @@ "main": "index.js",

test/tests.js

@@ -81,2 +81,16 @@ var { assert } = require('chai');
 
+  it('should default to 2048 bit keysize', function (done) {
+    var pems = generate();
+    var privateKey = forge.pki.privateKeyFromPem(pems.private);
+    assert.strictEqual(privateKey.n.bitLength(), 2048, 'default key size should be 2048 bits');
+    done();
+  });
+
+  it('should default to 2048 bit keysize for client certificate', function (done) {
+    var pems = generate(null, {clientCertificate: true});
+    var clientPrivateKey = forge.pki.privateKeyFromPem(pems.clientprivate);
+    assert.strictEqual(clientPrivateKey.n.bitLength(), 2048, 'default client key size should be 2048 bits');
+    done();
+  });
+
   describe('with callback', function () {
@@ -156,3 +170,21 @@ it('should work without attrs/options', function (done) {
     });
+
+    it('should default to 2048 bit keysize', function (done) {
+      generate(function (err, pems) {
+        if (err) done(err);
+        var privateKey = forge.pki.privateKeyFromPem(pems.private);
+        assert.strictEqual(privateKey.n.bitLength(), 2048, 'default key size should be 2048 bits');
+        done();
+      });
+    });
+
+    it('should default to 2048 bit keysize for client certificate', function (done) {
+      generate(null, {clientCertificate: true}, function (err, pems) {
+        if (err) done(err);
+        var clientPrivateKey = forge.pki.privateKeyFromPem(pems.clientprivate);
+        assert.strictEqual(clientPrivateKey.n.bitLength(), 2048, 'default client key size should be 2048 bits');
+        done();
+      });
+    });
   });
 });

No alert changes

Improved metrics

Total package byte prevSize

27718

6.21%

Number of package files

9

12.5%

Lines of code

460

9.79%

No dependency changes