serialport - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

changelog.md

@@ -0,1 +1,6 @@
+Version 1.0.3
+-------------
+- Fixed issue 65 - https://github.com/voodootikigod/node-serialport/issues/65
+- Added note in readme about what is required for the system to be able to compile module, should solve 90% of issues.
+
 Version 1.0.2
@@ -2,0 +7,0 @@ -------------

package.json

 {
   "name": "serialport",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Welcome your robotic javascript overlords. Better yet, program them!",
@@ -29,3 +29,4 @@ "author": {
     "sf": "0.1.3",
-    "optimist": "~0.3.4"
+    "optimist": "~0.3.4",
+    "node-gyp": "0.6.2"
   },
@@ -32,0 +33,0 @@ "engines": {

README.md

@@ -47,2 +47,17 @@ <pre>
 
+This assumes you have everything on your system necessary to compile ANY native module for Node.js. This may not be the case, though, so please ensure the following are true for your system before filing an issue about "Does not install". For all operatings systems, please ensure you have Python 2.x installed AND not 3.0, node-gyp (what we use to compile) requires Python 2.x.
+
+### Windows:
+
+Ensure you have Visual Studio 2010 installed. If you have any version OTHER THAN VS 2010, please read this: https://github.com/TooTallNate/node-gyp/issues/44 
+
+### Mac OS X:
+
+Ensure that you have at a minimum the xCode Command Line Tools installed appropriate for your system configuration. If you recently upgrade OS, it probably removed your installation of Command Line Tools, please verify before submitting a ticket.
+
+### Linux:
+
+You know what you need for you system, basically your appropriate analog of build-essential. Keep rocking!
+
+
 To Use
@@ -49,0 +64,0 @@ ------

serialport.js

@@ -154,6 +154,8 @@ "use strict";
 SerialPort.prototype.close = function (callback) {
+  var self = this;
+  
   var fd = this.fd;
   this.fd = 0;
 
-  if (this.closing) {
+  if (self.closing) {
     return;
@@ -169,5 +171,4 @@ }
 
-  this.closing = true;
+  self.closing = true;
   try {
-    var self = this;
     if (self.readStream) {
@@ -185,6 +186,6 @@ self.readStream.destroy();
       self.emit('close');
-      this.closing = false;
+      self.closing = false;
     });
   } catch (ex) {
-    this.closing = false;
+    self.closing = false;
     throw ex;
@@ -191,0 +192,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Mixed license

License

(Experimental) Package contains multiple licenses.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

225284

increased by9.81%

Number of package files

33

increased by17.86%

Number of lines in readme file

131

increased by12.93%

Worsened metrics

Dependency count

5

increased by25%

Number of low license alerts

2

increased by100%

Dependency changes

• + Addednode-gyp@0.6.2

• + Addedabbrev@1.1.1(transitive)

• + Addedansi@0.3.1(transitive)

• + Addedbalanced-match@1.0.2(transitive)

• + Addedblock-stream@0.0.9(transitive)

• + Addedbrace-expansion@1.1.11(transitive)

• + Addedconcat-map@0.0.1(transitive)

• + Addedfs.realpath@1.0.0(transitive)

• + Addedfstream@0.1.31(transitive)

• + Addedglob@3.2.117.2.3(transitive)

• + Addedgraceful-fs@1.2.33.0.12(transitive)

• + Addedinflight@1.0.6(transitive)

• + Addedinherits@2.0.4(transitive)

• + Addedisexe@2.0.0(transitive)

• + Addedlru-cache@2.7.3(transitive)

• + Addedminimatch@0.2.140.3.03.1.2(transitive)

• + Addedminimist@1.2.8(transitive)

• + Addedmkdirp@0.3.50.5.6(transitive)

• + Addednatives@1.1.6(transitive)

• + Addednode-gyp@0.6.2(transitive)

• + Addednopt@2.2.1(transitive)

• + Addednpmlog@0.1.1(transitive)

• + Addedonce@1.4.0(transitive)

• + Addedos-homedir@1.0.2(transitive)

• + Addedos-tmpdir@1.0.2(transitive)

• + Addedosenv@0.1.5(transitive)

• + Addedpath-is-absolute@1.0.1(transitive)

• + Addedrequest@2.9.203(transitive)

• + Addedrimraf@2.7.1(transitive)

• + Addedsemver@1.1.4(transitive)

• + Addedsigmund@1.0.1(transitive)

• + Addedtar@0.1.20(transitive)

• + Addedwhich@1.3.1(transitive)

• + Addedwrappy@1.0.2(transitive)