shaka-player - npm Package Compare versions

Comparing version 1.6.0 to 1.6.1

CHANGELOG.md

@@ -0,1 +1,10 @@
+## 1.6.1 (2015-12-07)
+
+Bugfixes:
+  - Fixed handling when all streams are removed in a manifest update.
+  - Fixed annotation mistakes in preparation for a new compiler release.
+  - Fixed Promise polyfill errors in compiled mode.
+    - https://github.com/google/shaka-player/issues/236
+
+
 ## 1.6.0 (2015-11-17)
@@ -2,0 +11,0 @@

externs/mediakeys.js

@@ -117,4 +117,4 @@ /**
 /**
- * The functor is called with each value.
- * @param {function(string)} fn
+ * The functor is called with each value and key.
+ * @param {function(string, BufferSource)} fn
  */
@@ -121,0 +121,0 @@ MediaKeyStatusMap.prototype.forEach = function(fn) {};

lib/player/player.js

@@ -136,3 +136,3 @@ /**
  */
-goog.define('GIT_VERSION', 'v1.6.0-debug');
+goog.define('GIT_VERSION', 'v1.6.1-debug');
 
@@ -139,0 +139,0 @@

lib/player/stats.js

@@ -100,3 +100,3 @@ /**
    *
-   * @type {!Array.<shaka.player.Stats.TimedValue.<number>>}
+   * @type {!Array.<!shaka.player.Stats.TimedValue.<number>>}
    * @expose
@@ -110,4 +110,4 @@ */
    *
-   * @type {!Array.<shaka.player.Stats.TimedValue.<
-   *            shaka.player.Stats.StreamStats>>}
+   * @type {!Array.<!shaka.player.Stats.TimedValue.<
+   *            !shaka.player.Stats.StreamStats>>}
    * @expose
@@ -114,0 +114,0 @@ */

lib/polyfill/patchedmediakeys_20140218.js

@@ -784,6 +784,3 @@ /**
 
-/**
- * Array entry 0 is the key, 1 is the value.
- * @return {Iterator.<Array.<!BufferSource|string>>}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.prototype.
@@ -802,10 +799,9 @@ entries = function() {
 
-/**
- * The functor is called with each value.
- * @param {function(string)} fn
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.prototype.
     forEach = function(fn) {
   if (this.status_) {
-    fn(this.status_);
+    var fakeKeyId =
+        shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.KEY_ID_;
+    fn(this.status_, fakeKeyId);
   }
@@ -815,6 +811,3 @@ };
 
-/**
- * @param {!BufferSource} keyId
- * @return {string|undefined}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.prototype.
@@ -829,6 +822,3 @@ get = function(keyId) {
 
-/**
- * @param {!BufferSource} keyId
- * @return {boolean}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.prototype.
@@ -846,5 +836,3 @@ has = function(keyId) {
 
-/**
- * @return {Iterator.<!BufferSource>}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.prototype.
@@ -863,5 +851,3 @@ keys = function() {
 
-/**
- * @return {Iterator.<string>}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v20140218.MediaKeyStatusMap.prototype.
@@ -868,0 +854,0 @@ values = function() {

lib/polyfill/patchedmediakeys_v01b.js

@@ -136,5 +136,4 @@ /**
   var videos = document.getElementsByTagName('video');
-  /** @type {!HTMLVideoElement} */
   var tmpVideo = videos.length ? videos[0] : document.createElement('video');
-  return tmpVideo;
+  return /** @type {!HTMLVideoElement} */(tmpVideo);
 };
@@ -927,6 +926,3 @@
 
-/**
- * Array entry 0 is the key, 1 is the value.
- * @override
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.entries =
@@ -945,10 +941,9 @@ function() {
 
-/**
- * The functor is called with each value.
- * @param {function(string)} fn
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.forEach =
     function(fn) {
   if (this.status_) {
-    fn(this.status_);
+    var fakeKeyId =
+        shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.KEY_ID_;
+    fn(this.status_, fakeKeyId);
   }
@@ -958,6 +953,3 @@ };
 
-/**
- * @param {BufferSource} keyId
- * @return {string|undefined}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.get =
@@ -972,6 +964,3 @@ function(keyId) {
 
-/**
- * @param {BufferSource} keyId
- * @return {boolean}
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.has =
@@ -989,5 +978,3 @@ function(keyId) {
 
-/**
- * @override
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.keys =
@@ -1006,5 +993,3 @@ function() {
 
-/**
- * @override
- */
+/** @override */
 shaka.polyfill.PatchedMediaKeys.v01b.MediaKeyStatusMap.prototype.values =
@@ -1011,0 +996,0 @@ function() {

lib/polyfill/promise.js

@@ -65,3 +65,8 @@ /**
 
-/** @typedef {{ promise: !shaka.polyfill.Promise, callback: function(*) }} */
+/**
+ * @typedef {{
+ *   promise: !shaka.polyfill.Promise,
+ *   callback: (function(*)|undefined)
+ * }}
+ */
 shaka.polyfill.Promise.Child;
@@ -91,4 +96,15 @@
   shaka.log.info('Using Promises polyfill.');
+  // Quoted to work around type-checking, since our then() signature doesn't
+  // exactly match that of a native Promise.
   window['Promise'] = shaka.polyfill.Promise;
 
+  // Explicitly installed because the compiler won't necessarily attach them
+  // to the compiled constructor.  Exporting them will only attach them to
+  // their original namespace, which isn't the same as attaching them to the
+  // constructor unless you also export the constructor.
+  window.Promise.resolve = shaka.polyfill.Promise.resolve;
+  window.Promise.reject = shaka.polyfill.Promise.reject;
+  window.Promise.all = shaka.polyfill.Promise.all;
+  window.Promise.race = shaka.polyfill.Promise.race;
+
   // Decide on the best way to invoke a callback as soon as possible.
@@ -95,0 +111,0 @@ // Precompute the Promise.soon_ convenience method to avoid the overhead

lib/util/content_database.js

@@ -128,5 +128,4 @@ /**
  * @typedef {{
- *    index: number,
  *    start_time: number,
- *    end_time: number,
+ *    end_time: ?number,
  *    start_byte: number,
@@ -133,0 +132,0 @@ *    url: string

package.json

 {
   "name": "shaka-player",
   "description": "DASH/EME video player library",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "homepage": "https://github.com/google/shaka-player",
@@ -6,0 +6,0 @@ "author": "Google",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

12087498

increased by0.08%

Lines of code

55682

No dependency changes