simple-oracledb - npm Package Compare versions

Comparing version 0.0.7 to 0.0.8

lib/connection.js

@@ -250,2 +250,4 @@ 'use strict';
         if (lobColumns && lobColumns.length) {
+            argumentsArray[2].autoCommit = false; //must disable auto commit to support LOBs
+
             var sql = [argumentsArray[0]];
@@ -252,0 +254,0 @@ var bindVariables = argumentsArray[1];

package.json

 {
   "name": "simple-oracledb",
-  "version": "0.0.7",
+  "version": "0.0.8",
   "description": "Extend capabilities of oracledb with simplified API for quicker development.",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -222,2 +222,3 @@ # simple-oracledb
 | ----------- | ------- | ----------- |
+| 2015-10-19  | v0.0.8  | autoCommit=false when doing INSERT/UPDATE with LOBs |
 | 2015-10-19  | v0.0.7  | Added pool.terminate support |
@@ -224,0 +225,0 @@ | 2015-10-19  | v0.0.6  | Maintenance |

test/integration/integration-spec.js

@@ -363,3 +363,3 @@ 'use strict';
 
-                        connection.insert('INSERT INTO ' + table + ' (COL1, COL2, LOB1, LOB2) values (:value1, :value2, :clob1, :blob2)', {
+                        connection.insert('INSERT INTO ' + table + ' (COL1, COL2, LOB1, LOB2) values (:value1, :value2, EMPTY_CLOB(), EMPTY_BLOB())', {
                             value1: 'test',
@@ -369,3 +369,8 @@ value2: 123,
                             blob2: new Buffer('blob text here')
-                        }, {}, function (error, results) {
+                        }, {
+                            lobMetaInfo: {
+                                LOB1: 'clob1',
+                                LOB2: 'blob2'
+                            }
+                        }, function (error, results) {
                             assert.isNull(error);
@@ -498,3 +503,3 @@ assert.equal(1, results.rowsAffected);
 
-            it('insert - LOB data', function (done) {
+            it('update - LOB data', function (done) {
                 var table = 'TEST_ORA_UPDT3';
@@ -514,3 +519,3 @@
 
-                        connection.insert('INSERT INTO ' + table + ' (COL1, COL2, LOB1, LOB2) values (:value1, :value2, :clob1, :blob2)', {
+                        connection.insert('INSERT INTO ' + table + ' (COL1, COL2, LOB1, LOB2) values (:value1, :value2, EMPTY_CLOB(), EMPTY_BLOB())', {
                             value1: 'test',
@@ -520,3 +525,8 @@ value2: 123,
                             blob2: new Buffer('blob text here')
-                        }, {}, function (error1, results1) {
+                        }, {
+                            lobMetaInfo: {
+                                LOB1: 'clob1',
+                                LOB2: 'blob2'
+                            }
+                        }, function (error1, results1) {
                             assert.isNull(error1);
@@ -523,0 +533,0 @@ assert.equal(1, results1.rowsAffected);

test/spec/connection-spec.js

@@ -345,2 +345,3 @@ 'use strict';
                 assert.deepEqual(options, {
+                    autoCommit: false,
                     lobMetaInfo: {
@@ -421,2 +422,3 @@ c1: 'lob1',
                 assert.deepEqual(options, {
+                    autoCommit: false,
                     lobMetaInfo: {
@@ -494,2 +496,3 @@ c1: 'lob1',
                 assert.deepEqual(options, {
+                    autoCommit: false,
                     lobMetaInfo: {
@@ -583,2 +586,3 @@ c1: 'lob1',
                 assert.deepEqual(options, {
+                    autoCommit: false,
                     lobMetaInfo: {
@@ -659,2 +663,3 @@ c1: 'lob1',
                 assert.deepEqual(options, {
+                    autoCommit: false,
                     lobMetaInfo: {
@@ -732,2 +737,3 @@ c1: 'lob1',
                 assert.deepEqual(options, {
+                    autoCommit: false,
                     lobMetaInfo: {
@@ -734,0 +740,0 @@ c1: 'lob1',

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

206228

increased by0.4%

Lines of code

4269

increased by0.4%

Number of lines in readme file

233

increased by0.43%

No dependency changes