simple-oracledb - npm Package Compare versions

Comparing version 0.1.23 to 0.1.24

lib/pool.js

@@ -69,3 +69,7 @@ 'use strict';
                         debug('Pooled connection validation failed, ', testError.stack);
-                        connection.release({}, function onConnectionRelease() {
+                        connection.release(function onConnectionRelease(releaseError) {
+                            if (releaseError) {
+                                debug('Unable to release connection, ', releaseError.stack);
+                            }
+
                             asyncCallback(testError);
@@ -72,0 +76,0 @@ });

package.json

 {
   "name": "simple-oracledb",
-  "version": "0.1.23",
+  "version": "0.1.24",
   "description": "Extend capabilities of oracledb with simplified API for quicker development.",
@@ -5,0 +5,0 @@ "author": {

README.md

@@ -481,2 +481,3 @@ # simple-oracledb
 | ----------- | ------- | ----------- |
+| 2016-02-10  | v0.1.24 | Maintenance |
 | 2016-02-10  | v0.1.23 | Adding debug logs via NODE_DEBUG=simple-oracledb |
@@ -483,0 +484,0 @@ | 2016-02-09  | v0.1.22 | Maintenance |

test/spec/pool-spec.js

@@ -33,3 +33,3 @@ 'use strict';
                 done();
-            })
+            });
         });
@@ -50,3 +50,3 @@
                 done();
-            })
+            });
         });
@@ -82,3 +82,3 @@
                 done();
-            })
+            });
         });
@@ -110,3 +110,3 @@
                 done();
-            })
+            });
         });
@@ -135,5 +135,32 @@
                 done();
-            })
+            });
         });
 
+        it('getConnection sql and release error', function (done) {
+            var testPool = oracledb.createPool();
+            var orgGetConnection = testPool.getConnection;
+
+            testPool.getConnection = function (callback) {
+                orgGetConnection.call(testPool, function (connError, connection) {
+                    connection.throwError = true;
+                    connection.release = function (cb) {
+                        cb(new Error('test'));
+                    };
+
+                    callback(null, connection);
+                });
+            };
+
+            Pool.extend(testPool, {
+                retryInterval: 5
+            });
+
+            testPool.getConnection(function (error, connection) {
+                assert.isDefined(error);
+                assert.isUndefined(connection);
+
+                done();
+            });
+        });
+
         it('getConnection sql error with valid retry', function (done) {
@@ -171,3 +198,3 @@ var testPool = oracledb.createPool();
                 done();
-            })
+            });
         });
@@ -174,0 +201,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

420247

increased by0.26%

Lines of code

9184

increased by0.26%

Number of lines in readme file

517

increased by0.19%

No dependency changes