simple-oracledb - npm Package Compare versions

Comparing version 1.1.32 to 1.1.33

docs/CHANGELOG.md

 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2016-10-13  | v1.1.32 | Maintenance |
+| 2016-10-16  | v1.1.33 | Maintenance |
 | 2016-10-07  | v1.1.26 | Added oracledb.run |
@@ -5,0 +5,0 @@ | 2016-10-06  | v1.1.25 | Maintenance |

lib/connection.js

@@ -1357,2 +1357,3 @@ 'use strict';
             } else {
+                /*eslint-disable func-name-matching*/
                 /**
@@ -1371,2 +1372,3 @@ * Pushes error event to the stream.
                 };
+                /*eslint-enable func-name-matching*/
             }
@@ -1393,3 +1395,3 @@ } else {
 
-    var wrapperCallback = function onCallback(error) {
+    var onWrapperCallback = function (error) {
         if (error) {
@@ -1418,3 +1420,3 @@ if (commit) {
 
-    return singleAsyncCallback(wrapperCallback);
+    return singleAsyncCallback(onWrapperCallback);
 };
@@ -1421,0 +1423,0 @@

lib/monitor.js

@@ -17,2 +17,3 @@ 'use strict';
 
+    /*eslint-disable func-name-matching*/
     /**
@@ -59,2 +60,3 @@ * True if the monitor is enabled and it will listen and store pool/connection diagnostics information.
     });
+    /*eslint-enable func-name-matching*/
     self.enabled = false;
@@ -91,2 +93,3 @@
 
+        /*eslint-disable func-name-matching*/
         Object.defineProperties(statsInfo, {
@@ -120,2 +123,3 @@ sql: {
         });
+        /*eslint-enable func-name-matching*/
 
@@ -147,2 +151,3 @@ self.diagnosticInfo.connection[id] = statsInfo;
 
+        /*eslint-disable func-name-matching*/
         Object.defineProperties(statsInfo, {
@@ -163,2 +168,3 @@ liveTime: {
         });
+        /*eslint-enable func-name-matching*/
 
@@ -165,0 +171,0 @@ var id = pool.diagnosticInfo.id;

lib/oracledb.js

@@ -85,3 +85,3 @@ 'use strict';
 
-    var wrapperCallback = function onConnection(error, connection) {
+    var onWrapperConnection = function (error, connection) {
         /*istanbul ignore else*/
@@ -99,3 +99,3 @@ if ((!error) && connection) {
 
-    self.baseGetConnection(connectionAttributes, Connection.wrapOnConnection(wrapperCallback));
+    self.baseGetConnection(connectionAttributes, Connection.wrapOnConnection(onWrapperConnection));
 };
@@ -102,0 +102,0 @@ //jscs:enable jsDoc

lib/pool.js

@@ -113,3 +113,3 @@ 'use strict';
 
-    var wrapperCallback = function onConnectionCreated(error, connection) {
+    var onWrapperConnectionCreated = function (error, connection) {
         /*istanbul ignore else*/
@@ -151,3 +151,3 @@ if ((!error) && connection) {
         });
-    }, Connection.wrapOnConnection(wrapperCallback));
+    }, Connection.wrapOnConnection(onWrapperConnectionCreated));
 };
@@ -154,0 +154,0 @@ //jscs:enable jsDoc

lib/promise-helper.js

@@ -40,7 +40,7 @@ 'use strict';
     var promise;
-    var callback;
+    var promiseCallback;
 
     if (global.Promise) {
         promise = new global.Promise(function runViaPromise(resolve, reject) {
-            callback = function promiseCallback(error, output) {
+            promiseCallback = function (error, output) {
                 if (error) {
@@ -53,3 +53,3 @@ reject(error);
 
-            run(callback);
+            run(promiseCallback);
         });
@@ -56,0 +56,0 @@ } else {

lib/resultset-reader.js

@@ -175,2 +175,3 @@ 'use strict';
 
+    /*eslint-disable func-name-matching*/
     /**
@@ -206,4 +207,5 @@ * Reads the next rows from the resultset and pushes via events.
     };
+    /*eslint-enable func-name-matching*/
 };
 
 module.exports = new ResultSetReader();

lib/rows-reader.js

@@ -49,2 +49,4 @@ 'use strict';
                 var orgAsyncCallback = asyncCallback;
+
+                /*eslint-disable func-name-matching*/
                 asyncCallback = function onCallback(rowError, data) {
@@ -55,2 +57,3 @@ deferFunction(function invokeCallback() {
                 };
+                /*eslint-enable func-name-matching*/
             }
@@ -57,0 +60,0 @@

lib/simple-oracledb.js

@@ -61,2 +61,3 @@ 'use strict';
 
+    /*eslint-disable func-name-matching*/
     Object.defineProperty(this, 'diagnosticInfo', {
@@ -122,2 +123,3 @@ /**
     });
+    /*eslint-enable func-name-matching*/
 }
@@ -124,0 +126,0 @@

lib/single-async-callback.js

@@ -13,7 +13,7 @@ 'use strict';
 module.exports = function wrap(callback) {
-    var wrapper;
+    var onAsyncCallback;
     if (callback) {
         var callbackCalled = false;
 
-        wrapper = function onAsyncCallback(error, data) {
+        onAsyncCallback = function (error, data) {
             if (!callbackCalled) {
@@ -27,3 +27,3 @@ callbackCalled = true;
 
-    return wrapper;
+    return onAsyncCallback;
 };

package.json

 {
   "name": "simple-oracledb",
-  "version": "1.1.32",
+  "version": "1.1.33",
   "description": "Extend capabilities of oracledb with simplified API for quicker development.",
@@ -5,0 +5,0 @@ "author": {

README.md

@@ -916,3 +916,3 @@ # simple-oracledb
 | ----------- | ------- | ----------- |
-| 2016-10-13  | v1.1.32 | Maintenance |
+| 2016-10-16  | v1.1.33 | Maintenance |
 | 2016-10-07  | v1.1.26 | Added oracledb.run |
@@ -919,0 +919,0 @@ | 2016-10-06  | v1.1.25 | Maintenance |

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

766416

increased by0.09%

Lines of code

16101

increased by0.09%

No dependency changes