simple-oracledb - npm Package Compare versions

Comparing version 1.1.34 to 1.1.35

docs/CHANGELOG.md

 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2016-10-16  | v1.1.34 | Maintenance |
+| 2016-10-17  | v1.1.35 | Maintenance |
 | 2016-10-07  | v1.1.26 | Added oracledb.run |
@@ -5,0 +5,0 @@ | 2016-10-06  | v1.1.25 | Maintenance |

lib/record-reader.js

@@ -31,3 +31,5 @@ 'use strict';
 RecordReader.prototype.getValue = function (field, info, callback) {
-    if ((field !== null) && (field !== undefined)) {
+    if ((field === null) || (field === undefined)) {
+        callback(null, field);
+    } else {
         var type = typeof field;
@@ -52,4 +54,2 @@
         }
-    } else {
-        callback();
     }
@@ -56,0 +56,0 @@ };

package.json

 {
   "name": "simple-oracledb",
-  "version": "1.1.34",
+  "version": "1.1.35",
   "description": "Extend capabilities of oracledb with simplified API for quicker development.",
@@ -5,0 +5,0 @@ "author": {

README.md

@@ -916,3 +916,3 @@ # simple-oracledb
 | ----------- | ------- | ----------- |
-| 2016-10-16  | v1.1.34 | Maintenance |
+| 2016-10-17  | v1.1.35 | Maintenance |
 | 2016-10-07  | v1.1.26 | Added oracledb.run |
@@ -919,0 +919,0 @@ | 2016-10-06  | v1.1.25 | Maintenance |

test/spec/record-reader-spec.js

@@ -15,4 +15,4 @@ 'use strict';
             RecordReader.getValue(null, info, function (error, value) {
-                assert.isUndefined(error);
-                assert.isUndefined(value);
+                assert.isNull(error);
+                assert.isNull(value);
 
@@ -28,3 +28,3 @@ assert.isUndefined(info.lobFound);
             RecordReader.getValue(undefined, info, function (error, value) {
-                assert.isUndefined(error);
+                assert.isNull(error);
                 assert.isUndefined(value);
@@ -31,0 +31,0 @@

test/spec/resultset-reader-spec.js

@@ -290,3 +290,3 @@ 'use strict';
                         COL3: undefined,
-                        COL4: undefined
+                        COL4: null
                     },
@@ -617,3 +617,3 @@ {
                         COL3: undefined,
-                        COL4: undefined
+                        COL4: null
                     }
@@ -1009,3 +1009,3 @@ ],
                     COL3: undefined,
-                    COL4: undefined
+                    COL4: null
                 },
@@ -1102,3 +1102,3 @@ {
                     COL3: undefined,
-                    COL4: undefined
+                    COL4: null
                 }
@@ -1214,3 +1214,3 @@ ];
                     COL3: undefined,
-                    COL4: undefined
+                    COL4: null
                 },
@@ -1217,0 +1217,0 @@ {

test/spec/rows-reader-spec.js

@@ -62,3 +62,3 @@ 'use strict';
                         COL3: undefined,
-                        COL4: undefined
+                        COL4: null
                     }
@@ -65,0 +65,0 @@ ], jsRows);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

16108

increased by0.04%

Worsened metrics

Total package byte prevSize

766269

decreased by-0.02%

No dependency changes