slonik - npm Package Compare versions

Comparing version 45.6.0 to 46.0.0

dist/factories/createConnectionPool.js

@@ -41,3 +41,5 @@ "use strict";
         await (0, promises_1.setTimeout)(0);
-        await Promise.all(connections.map((connection) => connection.destroy()));
+        // Make a copy of `connections` array as items are removed from it during the map iteration.
+        // If `connections` array is used directly, the loop will skip some items.
+        await Promise.all([...connections].map((connection) => connection.destroy()));
     };
@@ -59,3 +61,6 @@ const acquire = async () => {
             pendingConnections.push(pendingConnection);
-            const connection = await pendingConnection;
+            const connection = await pendingConnection.catch((error) => {
+                pendingConnections.pop();
+                throw error;
+            });
             const onRelease = () => {
@@ -62,0 +67,0 @@ const waitingClient = waitingClients.shift();

dist/helpers.test/createIntegrationTests.js

@@ -136,7 +136,8 @@ "use strict";
         const error = await t.throwsAsync(pool.any(__1.sql.unsafe `
-      INSERT INTO person (name) VALUES (null)
-    `));
+        INSERT INTO person (name) VALUES (null)
+      `));
         t.true(error instanceof __1.NotNullIntegrityConstraintViolationError);
-        t.is(error?.table, 'person');
-        t.is(error?.column, 'name');
+        const notNullIntegrityConstraintViolationError = error;
+        t.is(notNullIntegrityConstraintViolationError?.table, 'person');
+        t.is(notNullIntegrityConstraintViolationError?.column, 'name');
     });
@@ -163,3 +164,4 @@ test('properly handles terminated connections', async (t) => {
         t.true(error instanceof __1.InputSyntaxError);
-        t.is(error?.sql, 'SELECT WHERE');
+        const inputSyntaxError = error;
+        t.is(inputSyntaxError?.sql, 'SELECT WHERE');
         await pool.end();
@@ -718,3 +720,3 @@ });
             driverFactory,
-            idleTimeout: 500,
+            idleTimeout: 'DISABLE_TIMEOUT',
             maximumPoolSize: 5,
@@ -756,3 +758,2 @@ });
         await pool.end();
-        await (0, promises_1.setTimeout)(600);
         t.deepEqual(pool.state(), {
@@ -759,0 +760,0 @@ acquiredConnections: 0,

dist/integration.test/termination.test.d.ts

@@ -1,2 +0,5 @@
-export {};
+export declare const startTestContainer: () => Promise<{
+    dsn: string;
+    terminate: () => void;
+}>;
 //# sourceMappingURL=termination.test.d.ts.map

dist/integration.test/termination.test.js

@@ -7,2 +7,3 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.startTestContainer = void 0;
 const __1 = require("..");
@@ -60,2 +61,3 @@ const ava_1 = __importDefault(require("ava"));
 };
+exports.startTestContainer = startTestContainer;
 /**
@@ -73,3 +75,3 @@ * @see https://github.com/brianc/node-postgres/issues/3083
     }
-    const { dsn, terminate } = await startTestContainer();
+    const { dsn, terminate } = await (0, exports.startTestContainer)();
     const pool = await (0, __1.createPool)(dsn);
@@ -76,0 +78,0 @@ // eslint-disable-next-line promise/prefer-await-to-then

package.json

@@ -8,7 +8,7 @@ {
   "dependencies": {
-    "@slonik/driver": "^45.6.0",
-    "@slonik/errors": "^45.6.0",
-    "@slonik/pg-driver": "^45.6.0",
-    "@slonik/sql-tag": "^45.6.0",
-    "@slonik/utilities": "^45.6.0",
+    "@slonik/driver": "^46.0.0",
+    "@slonik/errors": "^46.0.0",
+    "@slonik/pg-driver": "^46.0.0",
+    "@slonik/sql-tag": "^46.0.0",
+    "@slonik/utilities": "^46.0.0",
     "get-stack-trace": "^3.1.1",
@@ -24,3 +24,3 @@ "iso8601-duration": "^1.3.0",
     "@types/sinon": "^10.0.20",
-    "ava": "^5.3.1",
+    "ava": "^6.1.3",
     "cspell": "^8.6.0",
@@ -34,3 +34,3 @@ "eslint": "^8.57.0",
     "ts-node": "^10.9.1",
-    "typescript": "^5.4.3",
+    "typescript": "^5.4.5",
     "zod": "^3.22.4"
@@ -89,3 +89,3 @@ },
   "types": "./dist/index.d.ts",
-  "version": "45.6.0"
+  "version": "46.0.0"
 }

src/factories/createConnectionPool.ts

@@ -111,3 +111,7 @@ import { Logger } from '../Logger';
 
-    await Promise.all(connections.map((connection) => connection.destroy()));
+    // Make a copy of `connections` array as items are removed from it during the map iteration.
+    // If `connections` array is used directly, the loop will skip some items.
+    await Promise.all(
+      [...connections].map((connection) => connection.destroy()),
+    );
   };
@@ -139,3 +143,6 @@
 
-      const connection = await pendingConnection;
+      const connection = await pendingConnection.catch((error) => {
+        pendingConnections.pop();
+        throw error;
+      });
 
@@ -142,0 +149,0 @@ const onRelease = () => {

src/helpers.test/createIntegrationTests.ts

@@ -179,12 +179,15 @@ /* eslint-disable id-length */
 
-    const error: NotNullIntegrityConstraintViolationError | undefined =
-      await t.throwsAsync(
-        pool.any(sql.unsafe`
-      INSERT INTO person (name) VALUES (null)
-    `),
-      );
+    const error: Error | undefined = await t.throwsAsync(
+      pool.any(sql.unsafe`
+        INSERT INTO person (name) VALUES (null)
+      `),
+    );
 
     t.true(error instanceof NotNullIntegrityConstraintViolationError);
-    t.is(error?.table, 'person');
-    t.is(error?.column, 'name');
+
+    const notNullIntegrityConstraintViolationError =
+      error as NotNullIntegrityConstraintViolationError;
+
+    t.is(notNullIntegrityConstraintViolationError?.table, 'person');
+    t.is(notNullIntegrityConstraintViolationError?.column, 'name');
   });
@@ -216,3 +219,3 @@
 
-    const error: InputSyntaxError | undefined = await t.throwsAsync(
+    const error: Error | undefined = await t.throwsAsync(
       pool.any(sql.unsafe`SELECT WHERE`),
@@ -223,4 +226,6 @@ );
 
-    t.is(error?.sql, 'SELECT WHERE');
+    const inputSyntaxError = error as InputSyntaxError;
 
+    t.is(inputSyntaxError?.sql, 'SELECT WHERE');
+
     await pool.end();
@@ -927,3 +932,3 @@ });
       driverFactory,
-      idleTimeout: 500,
+      idleTimeout: 'DISABLE_TIMEOUT',
       maximumPoolSize: 5,
@@ -970,4 +975,2 @@ });
 
-    await delay(600);
-
     t.deepEqual(pool.state(), {
@@ -974,0 +977,0 @@ acquiredConnections: 0,

src/integration.test/termination.test.ts

@@ -10,3 +10,3 @@ /* eslint-disable no-console */
 
-const startTestContainer = async () => {
+export const startTestContainer = async () => {
   const dockerContainerName = `slonik-test-${randomUUID()}`;
@@ -13,0 +13,0 @@ const servicePort = await getPort();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

650817

increased by0.86%

Number of package files

333

increased by1.52%

Lines of code

12956

increased by0.81%

Dependency changes

• + Added@slonik/driver@46.1.0(transitive)

• + Added@slonik/errors@46.1.0(transitive)

• + Added@slonik/pg-driver@46.1.0(transitive)

• + Added@slonik/sql-tag@46.1.0(transitive)

• + Added@slonik/types@46.1.0(transitive)

• + Added@slonik/utilities@46.1.0(transitive)

• - Removed@slonik/driver@45.6.0(transitive)

• - Removed@slonik/errors@45.6.0(transitive)

• - Removed@slonik/pg-driver@45.6.0(transitive)

• - Removed@slonik/sql-tag@45.6.0(transitive)

• - Removed@slonik/types@45.6.0(transitive)

• - Removed@slonik/utilities@45.6.0(transitive)

• Updated@slonik/driver@^46.0.0

• Updated@slonik/errors@^46.0.0

• Updated@slonik/pg-driver@^46.0.0

• Updated@slonik/sql-tag@^46.0.0

• Updated@slonik/utilities@^46.0.0