smaps - npm Package Compare versions

Comparing version 0.2.4 to 0.2.5

settings.json

+{
+  "SDB_PATH" : "/usr/bin/sdb",
+  "ADB_PATH" : "/usr/bin/adb"
+}

lib/android.js

@@ -6,2 +6,5 @@ var async = require('async');
 
+var settings = require('../settings.json');
+var BRIDGE_PATH = settings.ADB_PATH;
+
 function callChildProcess(command, cb) {
@@ -15,3 +18,3 @@ var exec = require('child_process').exec,
 function readProcCmdline(callback) {
-  callChildProcess('adb root on 1>/dev/null && adb shell ls /proc/', function(err, stdout, stderr){
+  callChildProcess(BRIDGE_PATH + ' root on 1>/dev/null && ' + BRIDGE_PATH + ' shell ls /proc/', function(err, stdout, stderr){
     if (err)
@@ -32,3 +35,3 @@ return callback(err);
     async.each(pids, function(pid, cb){
-      callChildProcess('adb root on 1>/dev/null && adb shell cat /proc/'+pid+'/cmdline', function(err, stdout, stderr){
+      callChildProcess(BRIDGE_PATH + ' root on 1>/dev/null && ' + BRIDGE_PATH + ' shell cat /proc/'+pid+'/cmdline', function(err, stdout, stderr){
         if (stdout.indexOf('No such file or directory') !== -1)
@@ -59,3 +62,3 @@ return cb();
 
-  callChildProcess('adb root on 1>/dev/null && adb shell cat /proc/'+pid+'/smaps', function(err, stdout, stderr){
+  callChildProcess(BRIDGE_PATH + ' root on 1>/dev/null && ' + BRIDGE_PATH + ' shell cat /proc/'+pid+'/smaps', function(err, stdout, stderr){
     if (stdout.indexOf('No such file or directory') !== -1)
@@ -62,0 +65,0 @@ return self.push(null);

lib/tizen.js

@@ -6,2 +6,5 @@ var async = require('async');
 
+var settings = require('../settings.json');
+var BRIDGE_PATH = settings.SDB_PATH;
+
 function callChildProcess(command, cb) {
@@ -15,3 +18,3 @@ var exec = require('child_process').exec,
 function readProcCmdline(callback) {
-  callChildProcess('sdb root on && sdb shell ls /proc/', function(err, stdout, stderr){
+  callChildProcess(BRIDGE_PATH + ' root on && ' + BRIDGE_PATH + ' shell ls /proc/', function(err, stdout, stderr){
     if (err)
@@ -32,3 +35,3 @@ return callback(err);
     async.each(pids, function(pid, cb){
-      callChildProcess('sdb root on && sdb shell cat /proc/'+pid+'/cmdline', function(err, stdout, stderr){
+      callChildProcess(BRIDGE_PATH + ' root on && ' + BRIDGE_PATH + ' shell cat /proc/'+pid+'/cmdline', function(err, stdout, stderr){
         if (stdout.indexOf('No such file or directory') !== -1) 
@@ -59,3 +62,3 @@ return cb();
 
-  callChildProcess('sdb root on && sdb shell cat /proc/'+pid+'/smaps', function(err, stdout, stderr){
+  callChildProcess(BRIDGE_PATH + ' root on && ' + BRIDGE_PATH + ' shell cat /proc/'+pid+'/smaps', function(err, stdout, stderr){
     if (stdout.indexOf('No such file or directory') !== -1) 
@@ -62,0 +65,0 @@ return self.push(null);

package.json

 {
   "name": "smaps",
-  "description": "pretty view of /proc/[0-9]/smaps",
-  "version": "0.2.4",
+  "description": "pretty view of /proc/[0-9]+/smaps",
+  "version": "0.2.5",
   "author": {
@@ -12,3 +12,3 @@ "name": "HoYong Jung",
     "test": "echo \"Error: no test specified\" && exit 1",
-    "start": "nodejs server.js"
+    "start": "node server.js"
   },
@@ -23,2 +23,3 @@ "license": "MIT",
     "smaps",
+    "memory",
     "linux",
@@ -25,0 +26,0 @@ "kernel",

README.md

@@ -7,3 +7,3 @@ # smaps - pretty view of smaps
 - Drag-n-drop a smaps file to browser in order to parse.
-- Samps to Excel Exports(thanks to Datatables)
+- Smaps to Excel Exports(thanks to Datatables)
 - Android device's smaps supports.
@@ -22,5 +22,5 @@ - Tizen device's smaps supports.
 
-     sudo DEBUG=* nodejs server.js
+     sudo DEBUG=* node server.js
 
-then, Navigate to http://localhost:8888 by your browser(ex, chrome).
+then, Navigate to http://localhost:8888 by browsers(ex, chrome).
 
@@ -32,3 +32,3 @@ ## Android
 
-then,
+and check ADB_PATH in settings.json, then
 
@@ -42,4 +42,4 @@ http://localhost:8888/android
 
-then,
+and check SDB_PATH in settings.json, then
 
      http://localhost:8888/tizen

routes/routerAndroid.js

@@ -18,3 +18,3 @@ var debug = require('debug')('smaps:routes:android');
       if (err)
-        return res.status(400).send('error.');
+        return res.status(400).send('error : ' + err);
 
@@ -21,0 +21,0 @@ res.send(cmdline);

routes/routerTizen.js

@@ -18,3 +18,3 @@ var debug = require('debug')('smaps:routes:tizen');
       if (err)
-        return res.status(400).send('error.');
+        return res.status(400).send('error : ' + err);
 
@@ -21,0 +21,0 @@ res.send(cmdline);

views/index.ejs

@@ -117,2 +117,3 @@ <html>
       console.log("error : " + error);
+      alert(xhr.responseText);
     }
@@ -119,0 +120,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

1382909

0.04%

Number of package files

36

2.86%

Lines of code

33185

0.02%

No dependency changes