smtp-connection - npm Package Compare versions

Comparing version 1.3.7 to 1.3.8

CHANGELOG.md

 # Changelog
 
+## v1.3.8 2015-12-29
+
+  * Do not use strict isEmail function, just check that there are no newlines in addresses. Fixes a regression with lax e-mail addresses.
+
 ## v1.3.7 2015-12-22
@@ -4,0 +8,0 @@

package.json

 {
   "name": "smtp-connection",
-  "version": "1.3.7",
+  "version": "1.3.8",
   "description": "Connect to SMTP servers",
@@ -35,5 +35,3 @@ "main": "src/smtp-connection.js",
   },
-  "dependencies": {
-    "isemail": "^1.2.0"
-  }
+  "dependencies": {}
 }

src/smtp-connection.js

@@ -11,3 +11,2 @@ 'use strict';
 var DataStream = require('./data-stream');
-var isemail = require('isemail');
 
@@ -571,8 +570,3 @@ module.exports = SMTPConnection;
 
-    if (this._envelope.from &&
-        isemail(this._envelope.from,
-            // isemail non smtp compatible error codes start from 17
-            {
-                errorLevel: 16
-            }) !== 0) {
+    if (this._envelope.from && /[\r\n<>]/.test(this._envelope.from)) {
         return callback(this._formatError('Invalid sender ' + JSON.stringify(this._envelope.from), 'EENVELOPE'));
@@ -582,8 +576,3 @@ }
     for (var i = 0, len = this._envelope.to.length; i < len; i++) {
-        if (!this._envelope.to[i] ||
-            isemail(this._envelope.to[i],
-                // isemail non smtp compatible error codes start from 17
-                {
-                    errorLevel: 16
-                }) !== 0) {
+        if (!this._envelope.to[i] || /[\r\n<>]/.test(this._envelope.to[i])) {
             return callback(this._formatError('Invalid recipient ' + JSON.stringify(this._envelope.to[i]), 'EENVELOPE'));
@@ -887,3 +876,3 @@ }
         }.bind(this);
-        this._sendCommand(new Buffer(0));
+        this._sendCommand('');
         return;
@@ -890,0 +879,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Dependency count

0

decreased by-100%

Worsened metrics

Total package byte prevSize

44168

decreased by-0.45%

Lines of code

980

decreased by-1.11%

Dependency changes

• - Removedisemail@^1.2.0

• - Removedisemail@1.2.0(transitive)