snabbdom - npm Package Compare versions

Comparing version 0.6.9 to 0.7.0

modules/attributes.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-var booleanAttrs = ["allowfullscreen", "async", "autofocus", "autoplay", "checked", "compact", "controls", "declare",
-    "default", "defaultchecked", "defaultmuted", "defaultselected", "defer", "disabled", "draggable",
-    "enabled", "formnovalidate", "hidden", "indeterminate", "inert", "ismap", "itemscope", "loop", "multiple",
-    "muted", "nohref", "noresize", "noshade", "novalidate", "nowrap", "open", "pauseonexit", "readonly",
-    "required", "reversed", "scoped", "seamless", "selected", "sortable", "spellcheck", "translate",
-    "truespeed", "typemustmatch", "visible"];
 var xlinkNS = 'http://www.w3.org/1999/xlink';
@@ -13,6 +7,2 @@ var xmlNS = 'http://www.w3.org/XML/1998/namespace';
 var xChar = 120;
-var booleanAttrsDict = Object.create(null);
-for (var i = 0, len = booleanAttrs.length; i < len; i++) {
-    booleanAttrsDict[booleanAttrs[i]] = true;
-}
 function updateAttrs(oldVnode, vnode) {
@@ -31,10 +21,8 @@ var key, elm = vnode.elm, oldAttrs = oldVnode.data.attrs, attrs = vnode.data.attrs;
         if (old !== cur) {
-            if (booleanAttrsDict[key]) {
-                if (cur) {
-                    elm.setAttribute(key, "");
-                }
-                else {
-                    elm.removeAttribute(key);
-                }
+            if (cur === true) {
+                elm.setAttribute(key, "");
             }
+            else if (cur === false) {
+                elm.removeAttribute(key);
+            }
             else {
@@ -41,0 +29,0 @@ if (key.charCodeAt(0) !== xChar) {

modules/dataset.js

@@ -16,3 +16,5 @@ "use strict";
             if (d) {
-                delete d[key];
+                if (key in d) {
+                    delete d[key];
+                }
             }
@@ -19,0 +21,0 @@ else {

package.json

 {
   "name": "snabbdom",
-  "version": "0.6.9",
+  "version": "0.7.0",
   "description": "A virtual DOM library with focus on simplicity, modularity, powerful features and performance.",
@@ -13,14 +13,14 @@ "main": "snabbdom.js",
   "devDependencies": {
-    "benchmark": "^1.0.0",
-    "browserify": "^13.0.0",
-    "fake-raf": "0.0.1",
+    "benchmark": "^2.1.4",
+    "browserify": "^14.4.0",
+    "fake-raf": "1.0.1",
     "gulp": "^3.9.1",
     "gulp-clean": "^0.3.2",
     "gulp-rename": "^1.2.2",
-    "gulp-sourcemaps": "^1.6.0",
-    "gulp-uglify": "^1.5.3",
+    "gulp-sourcemaps": "^2.6.0",
+    "gulp-uglify": "^3.0.0",
     "knuth-shuffle": "^1.0.1",
-    "testem": "^1.0.2",
-    "typescript": "^2.1.0",
-    "xyz": "0.5.x"
+    "testem": "^1.18.1",
+    "typescript": "^2.4.2",
+    "xyz": "2.1.0"
   },
@@ -27,0 +27,0 @@ "scripts": {

README.md

@@ -6,2 +6,4 @@ # Snabbdom
 
+[![License: MIT](https://img.shields.io/badge/License-MIT-brightgreen.svg)](https://opensource.org/licenses/MIT) [![npm version](https://badge.fury.io/js/snabbdom.svg)](https://badge.fury.io/js/snabbdom) [![npm downloads](https://img.shields.io/npm/dm/snabbdom.svg)](https://www.npmjs.com/package/snabbdom)
+
 [![Join the chat at https://gitter.im/paldepind/snabbdom](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/paldepind/snabbdom?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
@@ -670,2 +672,3 @@
   A javascript library for rendering html. Tung helps to divide html and javascript development.
+* [sprotty](https://github.com/theia-ide/sprotty) - "A web-based diagramming framework" uses Snabbdom.
 
@@ -672,0 +675,0 @@ Be sure to share it if you're building an application in another way

src/modules/attributes.ts

@@ -6,9 +6,2 @@ import {VNode, VNodeData} from '../vnode';
 
-const booleanAttrs = ["allowfullscreen", "async", "autofocus", "autoplay", "checked", "compact", "controls", "declare",
-                "default", "defaultchecked", "defaultmuted", "defaultselected", "defer", "disabled", "draggable",
-                "enabled", "formnovalidate", "hidden", "indeterminate", "inert", "ismap", "itemscope", "loop", "multiple",
-                "muted", "nohref", "noresize", "noshade", "novalidate", "nowrap", "open", "pauseonexit", "readonly",
-                "required", "reversed", "scoped", "seamless", "selected", "sortable", "spellcheck", "translate",
-                "truespeed", "typemustmatch", "visible"];
-
 const xlinkNS = 'http://www.w3.org/1999/xlink';
@@ -18,8 +11,3 @@ const xmlNS = 'http://www.w3.org/XML/1998/namespace';
 const xChar = 120;
-const booleanAttrsDict: {[attribute: string]: boolean} = Object.create(null);
 
-for (let i = 0, len = booleanAttrs.length; i < len; i++) {
-  booleanAttrsDict[booleanAttrs[i]] = true;
-}
-
 function updateAttrs(oldVnode: VNode, vnode: VNode): void {
@@ -40,8 +28,6 @@ var key: string, elm: Element = vnode.elm as Element,
     if (old !== cur) {
-      if (booleanAttrsDict[key]) {
-        if (cur) {
-          elm.setAttribute(key, "");
-        } else {
-          elm.removeAttribute(key);
-        }
+      if (cur === true) {
+        elm.setAttribute(key, "");
+      } else if (cur === false) {
+        elm.removeAttribute(key);
       } else {
@@ -48,0 +34,0 @@ // because those in TypeScript are too restrictive: https://github.com/Microsoft/TSJS-lib-generator/pull/237

src/modules/dataset.ts

@@ -23,3 +23,5 @@ import {VNode, VNodeData} from '../vnode';
       if (d) {
-        delete d[key];
+        if (key in d) {
+          delete d[key];
+        }
       } else {
@@ -42,2 +44,2 @@ elm.removeAttribute('data-' + key.replace(CAPS_REGEX, '-$&').toLowerCase());
 export const datasetModule = {create: updateDataset, update: updateDataset} as Module;
-export default datasetModule;
+export default datasetModule;

src/snabbdom.ts

@@ -32,3 +32,3 @@ /* global module, document, Node */
 function createKeyToOldIdx(children: Array<VNode>, beginIdx: number, endIdx: number): KeyToIndexMap {
-  let i: number, map: KeyToIndexMap = {}, key: Key, ch;
+  let i: number, map: KeyToIndexMap = {}, key: Key | undefined, ch;
   for (i = beginIdx; i <= endIdx; ++i) {
@@ -35,0 +35,0 @@ ch = children[i];

src/tovnode.ts

@@ -35,3 +35,3 @@ import vnode, {VNode} from './vnode';
   } else {
-    return vnode('', {}, [], undefined, undefined);
+    return vnode('', {}, [], undefined, node as any);
   }
@@ -38,0 +38,0 @@ }

src/vnode.ts

@@ -19,3 +19,3 @@ import {Hooks} from './hooks';
   text: string | undefined;
-  key: Key;
+  key: Key | undefined;
 }
@@ -22,0 +22,0 @@

tovnode.js

@@ -39,3 +39,3 @@ "use strict";
     else {
-        return vnode_1.default('', {}, [], undefined, undefined);
+        return vnode_1.default('', {}, [], undefined, node);
     }
@@ -42,0 +42,0 @@ }

vnode.d.ts

@@ -17,3 +17,3 @@ import { Hooks } from './hooks';
     text: string | undefined;
-    key: Key;
+    key: Key | undefined;
 }
@@ -20,0 +20,0 @@ export interface VNodeData {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of lines in readme file

676

increased by0.45%

Worsened metrics

Total package byte prevSize

699111

decreased by-3.38%

Number of package files

119

decreased by-6.3%

Lines of code

7164

decreased by-0.26%

No dependency changes