sntp - npm Package Compare versions

Comparing version 0.2.2 to 0.2.3

examples/offset.js

@@ -0,0 +0,0 @@ var Sntp = require('../lib');

examples/time.js

@@ -0,0 +0,0 @@ var Sntp = require('../lib');

lib/index.js

@@ -42,2 +42,3 @@ // Load modules
             isFinished = true;
+            socket.removeAllListeners();
             socket.close();
@@ -52,3 +53,3 @@ return callback(err, result);
 
-    socket.on('error', function (err) {
+    socket.once('error', function (err) {
 
@@ -55,0 +56,0 @@ return finish(err);

package.json

 {
   "name": "sntp",
   "description": "SNTP Client",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "author": "Eran Hammer <[e-mail]> (http://hueniverse.com)",
@@ -6,0 +6,0 @@ "contributors": [],

test/index.js

@@ -67,4 +67,24 @@ // Load modules
 
-        it('times out on no response', function (done) {
+        it('errors on error event', function (done) {
 
+            var orig = Dgram.createSocket;
+            Dgram.createSocket = function (type) {
+
+                Dgram.createSocket = orig;
+                var socket = Dgram.createSocket(type);
+                process.nextTick(function () { socket.emit('error', new Error('Fake')) });
+                return socket;
+            };
+
+            Sntp.time(function (err, time) {
+
+                expect(err).to.exist;
+                expect(time).to.not.exist;
+                expect(err.message).to.equal('Fake');
+                done();
+            });
+        });
+
+        it('times out on invalid host', function (done) {
+
             Sntp.time({ host: 'error', timeout: 10000 }, function (err, time) {
@@ -71,0 +91,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

26505

increased by4.42%

Lines of code

557

increased by2.96%

No dependency changes