snyk-nuget-plugin - npm Package Compare versions

Comparing version 1.3.9 to 1.4.0

lib/dependency.js

@@ -7,4 +7,2 @@ var debug = require('debug')('snyk');
   this.dependencies = {};
-  this.versionSpec = 'unknown';
-  this.from = [];
 }
@@ -15,3 +13,2 @@
   var result = new Dependency(this.name, this.version);
-  result.versionSpec = this.versionSpec;
   return result;
@@ -46,3 +43,2 @@ };
       manifest.$.version);
-    result.versionSpec = manifest.$.version;
     return result;
@@ -49,0 +45,0 @@ },

lib/formats/dotnet-core-parser.js

@@ -1,2 +0,2 @@
-var Dependecy = require('../dependency');
+var Dependency = require('../dependency');
 var debug = require('debug')('snyk');
@@ -23,3 +23,3 @@
   packageTree.dependencies[name] =
-    packageTree.dependencies[name] || new Dependecy(name, version);
+    packageTree.dependencies[name] || new Dependency(name, version);
   debug(resolvedName);
@@ -33,3 +33,2 @@ }
     packageTree.version = manifest.project.version;
-    packageTree.from[0] = packageTree.name + '@' + packageTree.version;
   }
@@ -68,5 +67,5 @@ var targets = Object
             dependency.dependencies[key] =
-              new Dependecy(key, packageTree.dependencies[key].version);
+              new Dependency(key, packageTree.dependencies[key].version);
           } else {
-            dependency.dependencies[key] = new Dependecy(key, version);
+            dependency.dependencies[key] = new Dependency(key, version);
           }
@@ -81,25 +80,8 @@ }
 
-  // restructure tree with "from" chains.
-  function buildPath(node, from) {
-
-    node.from = node.from.concat(from);
-    Object.keys(node.dependencies).forEach(function (key) {
-      var depFrom = node.from.concat(node.name + '@' + node.version);
-      buildPath(node.dependencies[key], depFrom);
-    });
-    node.from = node.from.concat(node.name + '@' + node.version);
-  }
-
   // to disconnect the object references inside the tree
   // JSON parse/stringify is used
   var pathedTree = JSON.parse(JSON.stringify(packageTree.dependencies));
-
-  Object.keys(pathedTree).forEach(function (key) {
-    buildPath(pathedTree[key], [packageTree.name + '@' + packageTree.version]);
-  });
-
   packageTree.dependencies = pathedTree;
 }
 
-
 module.exports = parse;

lib/index.js

 var fs = require('fs');
 var parseXML = require('xml2js').parseString;
 var Promise = require('es6-promise').Promise;
-var Dependecy = require('./dependency');
-var findFolder = require('./find-folder');
+var Dependency = require('./dependency');
 var path = require('path');
@@ -60,3 +59,2 @@ var parseNuspec = require('./nuspec-parser');
           packageFormatVersion: 'nuget:0.0.0',
-          from: [path.basename(root || projectRootFolder) + '@0.0.0'],
           dependencies: {},
@@ -89,3 +87,3 @@ },
               var version = rawDependencies[name];
-              var newDependency = new Dependecy(name, version, null);
+              var newDependency = new Dependency(name, version, null);
               if (newDependency.name.indexOf('System.') !== 0) {
@@ -113,3 +111,3 @@ installedPackages.push(newDependency);
                     var installedDependency =
-                      Dependecy.from.packgesConfigEntry(node);
+                      Dependency.from.packgesConfigEntry(node);
                     installedPackages.push(installedDependency);
@@ -142,3 +140,3 @@ }
             .map(function (folderName) {
-              return Dependecy.from.folderName(folderName);
+              return Dependency.from.folderName(folderName);
             })
@@ -199,4 +197,2 @@ .forEach(function (dep) {
       function buildTree(node, requiredChildren, repository) {
-        var resolutionName = node.name + '@' + node.version;
-        node.from = node.from.concat(resolutionName);
         requiredChildren.forEach(function (requiredChild) {
@@ -208,12 +204,8 @@ var transitiveDependency;
               flattendPackageList[requiredChild.name].cloneShallow();
-            transitiveDependency.versionSpec =
-              requiredChild.versionSpec || transitiveDependency.versionSpec;
           } else {
             // create as new (uninstalled)
-            transitiveDependency = new Dependecy(
+            transitiveDependency = new Dependency(
               requiredChild.name,
               requiredChild.version);
-            transitiveDependency.versionSpec = requiredChild.version;
           }
-          transitiveDependency.from = node.from.concat();
           var transitiveChildren =
@@ -240,3 +232,2 @@ (nuspecResolutions[transitiveDependency.name] &&
           var node = flattendPackageList[resolution.name].cloneShallow();
-          node.from = tree.from.concat();
           buildTree(node, resolution.children, flattendPackageList);
@@ -243,0 +234,0 @@ tree.dependencies[node.name] = node;

lib/nuspec-parser.js

@@ -39,3 +39,2 @@ var zip = require('zip');
                 var transitiveDependency = new Dependency(dep.$.id, dep.$.version); // jscs:ignore
-                transitiveDependency.versionSpec = dep.$.versionSpec;
                 ownDependencies.push(transitiveDependency);
@@ -47,3 +46,2 @@ });
                 new Dependency(dep.$.id, dep.$.version, null);
-              transitiveDependency.versionSpec = dep.$.version;
               ownDependencies.push(transitiveDependency);
@@ -50,0 +48,0 @@ });

package.json

@@ -1,1 +0,1 @@
-{"name":"snyk-nuget-plugin","description":"![logo](https://res.cloudinary.com/snyk/image/upload/v1468845259/logo/snyk-dog.svg) ## Snyk: NuGet Plugin ***","main":"lib/index.js","scripts":{"lint":"jscs `find ./lib -name '*.js'` -v && jscs `find ./test -name '*.js'` -v","test":"npm run unit-test","test-windows":"tap -R spec test/*.test.js --timeout=120","unit-test":"tap `ls ./test/*.test.js` -R=spec","dev":"nodemon -x 'npm run unit-test'","semantic-release":"semantic-release pre && npm publish && semantic-release post"},"repository":{"type":"git","url":"https://github.com/snyk/snyk-nuget-plugin.git"},"keywords":["snyk","nuget"],"author":"snyk.io","license":"Apache-2.0","bugs":{"url":"https://github.com/snyk/snyk-nuget-plugin/issues"},"homepage":"https://github.com/snyk/snyk-nuget-plugin#readme","dependencies":{"debug":"^3.1.0","es6-promise":"^4.1.1","xml2js":"^0.4.17","zip":"^1.2.0"},"devDependencies":{"jscs":"^3.0.7","nodemon":"^1.12.1","semantic-release":"^8.2.0","tap":"^10.7.0","tap-only":"0.0.5"},"version":"1.3.9"}
+{"name":"snyk-nuget-plugin","description":"![logo](https://res.cloudinary.com/snyk/image/upload/v1468845259/logo/snyk-dog.svg) ## Snyk: NuGet Plugin ***","main":"lib/index.js","scripts":{"lint":"jscs `find ./lib -name '*.js'` -v && jscs `find ./test -name '*.js'` -v","test":"npm run unit-test","test-windows":"tap -R spec test/*.test.js --timeout=120","unit-test":"tap `ls ./test/*.test.js` -R=spec","dev":"nodemon -x 'npm run unit-test'","semantic-release":"semantic-release pre && npm publish && semantic-release post"},"repository":{"type":"git","url":"https://github.com/snyk/snyk-nuget-plugin.git"},"keywords":["snyk","nuget"],"author":"snyk.io","license":"Apache-2.0","bugs":{"url":"https://github.com/snyk/snyk-nuget-plugin/issues"},"homepage":"https://github.com/snyk/snyk-nuget-plugin#readme","dependencies":{"debug":"^3.1.0","es6-promise":"^4.1.1","xml2js":"^0.4.17","zip":"^1.2.0"},"devDependencies":{"jscs":"^3.0.7","nodemon":"^1.12.1","semantic-release":"^8.2.0","tap":"^10.7.0","tap-only":"0.0.5"},"version":"1.4.0"}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

19557

decreased by-6.56%

Lines of code

481

decreased by-5.5%

No dependency changes