snyk-sbt-plugin - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

lib/index.js

 var path = require('path');
 var subProcess = require('./sub-process');
-var parse = require('./parse-sbt');
+var parser = require('./parse-sbt');
 var packageFormatVersion = 'mvn:0.0.1';
@@ -18,3 +18,3 @@
     var packageVersion = '0.0.0';
-    var depTree = parse(result, packageName, packageVersion);
+    var depTree = parser.parse(result, packageName, packageVersion);
     depTree.packageFormatVersion = packageFormatVersion;
@@ -29,2 +29,9 @@
     };
+  })
+  .catch(function (error) {
+    var thrownError = parser.parseError(error);
+    if (thrownError) {
+      throw thrownError;
+    }
+    throw new Error('An unknown error occurred.');
   });
@@ -31,0 +38,0 @@ }

lib/parse-sbt.js

@@ -96,2 +96,10 @@ var tabdown = require('./tabdown');
 
+function parseError(text) {
+  if (text.indexOf('Not a valid command: dependency-tree') !== -1) {
+    return new Error('Plugin missing `sbt-dependency-graph` ' +
+      '(https://github.com/jrudolph/sbt-dependency-graph). ' +
+      'Please install it globally or on the current project and try again.');
+  }
+}
+
 function parse(text, name, version) {
@@ -109,2 +117,5 @@ var tree = converStrToTree(text);
 
-module.exports = parse;
+module.exports = {
+  parse: parse,
+  parseError: parseError,
+};

package.json

@@ -14,3 +14,3 @@ {
     "test-functional": "tap `find ./test/functional -name '*.test.js'`",
-    "test-system": "tap `find ./test/system -name '*.test.js'`",
+    "test-system": "tap --timeout=300 `find ./test/system -name '*.test.js'`",
     "semantic-release": "semantic-release pre && npm publish && semantic-release post"
@@ -28,3 +28,3 @@ },
   },
-  "version": "1.0.0"
+  "version": "1.0.1"
 }

test/functional/parse-sbt.test.js

@@ -0,10 +1,11 @@
+var fs = require('fs');
+var path = require('path');
 var test = require('tap-only');
-var parse = require('../../lib/parse-sbt');
-var fs = require('fs');
+var parser = require('../../lib/parse-sbt');
 
 test('parse a `sbt dependencies` output', function (t) {
   t.plan(4);
-  var sbtOutput = fs.readFileSync(
-    __dirname + '/../fixtures/sbt-dependency-output.txt', 'utf8');
-  var depTree = parse(sbtOutput, 'testApp', '1.0.1');
+  var sbtOutput = fs.readFileSync(path.join(
+    __dirname, '..', 'fixtures', 'sbt-dependency-output.txt'), 'utf8');
+  var depTree = parser.parse(sbtOutput, 'testApp', '1.0.1');
 
@@ -47,1 +48,10 @@ t.equal(depTree
 });
+
+
+test('parse an error output', function (t) {
+  t.plan(1);
+  var sbtOutput = fs.readFileSync(path.join(
+    __dirname, '..', 'fixtures', 'sbt-no-plugin-output.txt'), 'utf8');
+  var error = parser.parseError(sbtOutput, 'testApp', '1.0.1');
+  t.type(error, 'object', 'Error thrown correctly');
+});

test/system/plugin.test.js

@@ -0,9 +1,10 @@
+var fs = require('fs');
+var path = require('path');
 var test = require('tap-only');
 var plugin = require('../../lib');
-var fs = require('fs');
 
 test('run inspect()', function (t) {
   t.plan(1);
-  return plugin.inspect(
-    __dirname + '/../fixtures/testproj/',
+  return plugin.inspect(path.join(
+    __dirname, '..', 'fixtures', 'testproj'),
     'build.sbt')
@@ -20,1 +21,11 @@ .then(function (result) {
 });
+
+test('run inspect() with no sbt plugin', function (t) {
+  t.plan(1);
+  return plugin.inspect(path.join(
+    __dirname, '..', 'fixtures', 'testproj-noplugin'),
+    'build.sbt')
+  .catch(function (result) {
+    t.pass('Error thrown correctly');
+  });
+});

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1554629

increased by0.15%

Number of package files

25

increased by25%

Lines of code

323

increased by12.15%

No dependency changes