soap - npm Package Compare versions

Comparing version 0.19.1 to 0.19.2

History.md

@@ -0,1 +1,8 @@
+0.19.2 / 2017-06-12
+===================
+* [FIX] Recursive types cause infinite loop (#940)
+* [DOC] Adding a note about consulting in the README. (#939)
+* [MAINTENANCE] Add yarn.lock to gitignore (#938)
+* [MAINTENANCE] Remove dependency to ursa (#928)
+
 0.19.1 / 2017-05-30
@@ -2,0 +9,0 @@ ===================

lib/security/WSSecurityCert.js

 "use strict";
 
-var optional = require("optional");
-var ursa = optional('ursa');
 var fs = require('fs');
@@ -39,11 +37,10 @@ var path = require('path');
 
-function WSSecurityCert(privatePEM, publicP12PEM, password, encoding) {
-  if (!ursa) {
-    throw new Error('Module ursa must be installed to use WSSecurityCert');
-  }
-  this.privateKey = ursa.createPrivateKey(privatePEM, password, encoding);
+function WSSecurityCert(privatePEM, publicP12PEM, password) {
   this.publicP12PEM = publicP12PEM.toString().replace('-----BEGIN CERTIFICATE-----', '').replace('-----END CERTIFICATE-----', '').replace(/(\r\n|\n|\r)/gm, '');
 
   this.signer = new SignedXml();
-  this.signer.signingKey = this.privateKey.toPrivatePem();
+  this.signer.signingKey = {
+    key: privatePEM,
+    passphrase: password
+  };
   this.x509Id = "x509-" + generateId();
@@ -50,0 +47,0 @@

package.json

 {
   "name": "soap",
-  "version": "0.19.1",
+  "version": "0.19.2",
   "description": "A minimal node SOAP client",
@@ -16,3 +16,2 @@ "engines": {
     "lodash": "^3.10.1",
-    "optional": "^0.1.3",
     "request": ">=2.9.0",
@@ -26,5 +25,2 @@ "sax": ">=0.6",
   },
-  "optionalDependencies": {
-    "ursa": "0.8.5 || >=0.9.4"
-  },
   "repository": {
@@ -31,0 +27,0 @@ "type": "git",

Readme.md

@@ -12,5 +12,6 @@ # Soap [![NPM version][npm-image]][npm-url] [![Downloads][downloads-image]][npm-url] [![Build Status][travis-image]][travis-url] [![Coveralls Status][coveralls-image]][coveralls-url] [![Gitter chat][gitter-image]][gitter-url]
 
-- [Features:](#features)
+- [Features](#features)
 - [Install](#install)
-- [Where can I file an issue?](#where-can-i-file-an-issue)
+- [Why can't I file an issue?](#why-cant-i-file-an-issue)
+- [Where can I find help?](#where-can-i-find-help)
 - [Module](#module)
@@ -69,10 +70,14 @@ - [soap.createClient(url[, options], callback) - create a new SOAP client from a WSDL url. Also supports a local filesystem path.](#soapcreateclienturl-options-callback---create-a-new-soap-client-from-a-wsdl-url-also-supports-a-local-filesystem-path)
 
-## Where can I file an issue?
+## Why can't I file an issue?
 
 We've disabled issues in the repository and are now solely reviewing pull requests.  The reasons why we disabled issues can be found here [#731](https://github.com/vpulim/node-soap/pull/731).
 
-If you're in need of support we encourage you to join us and other `node-soap` users on gitter:
+## Where can I find help?
 
+Community support can be found on gitter:
+
 [![Gitter chat][gitter-image]][gitter-url]
 
+If you're looking for professional help you can contact the maintainers through this [google form](https://docs.google.com/forms/d/e/1FAIpQLSdj5EXxd5flcukLInmpFQhEvQYeERaReFFh9F0nqC_4EUmeLg/viewform).
+
 ## Module
@@ -537,8 +542,6 @@
   var password = ''; // optional password
-  var wsSecurity = new soap.WSSecurityCert(privateKey, publicKey, password, 'utf8');
+  var wsSecurity = new soap.WSSecurityCert(privateKey, publicKey, password);
   client.setSecurity(wsSecurity);
 ```
 
-_Note_: Optional dependency 'ursa' is required to be installed successfully when WSSecurityCert is used.
-
 ## Handling XML Attributes, Value and XML (wsdlOptions).
@@ -545,0 +548,0 @@ Sometimes it is necessary to override the default behaviour of `node-soap` in order to deal with the special requirements

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

180885

increased by0.18%

Dependency count

13

decreased by-13.33%

Lines of code

3539

increased by0.17%

Number of lines in readme file

856

increased by0.35%

Dependency changes

• - Removedoptional@^0.1.3

• - Removedoptional@0.1.4(transitive)