socket.io - npm Package Compare versions

Comparing version 0.6.16 to 0.6.17

History.md

 
+0.6.17 / 2011-03-30 
+==================
+
+  * Fixed the 'possible EventEmitter memory leak detected' bug for the XHR transport
+  * Reconnection support added to chat example. [3rd-Eden]
+
 0.6.16 / 2011-03-04
@@ -3,0 +9,0 @@ ===================

lib/socket.io/client.js

@@ -64,4 +64,5 @@ var urlparse = require('url').parse
 Client.prototype._onConnect = function(req, res){
-  var self = this;
-  
+  var self = this
+    , attachConnection = !this.connection;
+
   this.request = req;
@@ -71,19 +72,28 @@ this.response = res;
 
-  this.connection.addListener('end', function(){
-    self._onClose();
-    if (self.connection)
-      self.connection.destroy();
-  });
+  if(!attachConnection) attachConnection = !attachConnection && this.connection.eventsAttached === undefined;
+  this.connection.eventsAttached = true;
   
+  if (attachConnection){
+    function destroyConnection(){
+      self._onClose();
+      self.connection && self.connection.destroy()
+    };
+    this.connection.addListener('end', destroyConnection);
+    this.connection.addListener('timeout', destroyConnection);
+    this.connection.addListener('error', destroyConnection);
+    }
+  
   if (req){
-    req.addListener('error', function(err){
+    function destroyRequest(){
       req.destroy && req.destroy();
-    });
-    if (res) res.addListener('error', function(err){
-      res.destroy && res.destroy();
-    });
-    req.connection.addListener('error', function(err){
-      req.connection.destroy && req.connection.destroy();
-    });
-    
+    };
+    req.addListener('error', destroyRequest);
+    req.addListener('timeout', destroyRequest);
+    if (res){
+      function destroyResponse(){
+        res.destroy && res.destroy();
+      }
+      res.addListener('error', destroyResponse);
+      res.addListener('timeout', destroyResponse);
+    }
     if (this._disconnectTimeout) clearTimeout(this._disconnectTimeout);
@@ -93,2 +103,3 @@ }
 
+
 Client.prototype._payload = function(){
@@ -95,0 +106,0 @@ var payload = [];

lib/socket.io/index.js

@@ -26,2 +26,2 @@
 
-exports.version = '0.6.16';
+exports.version = '0.6.17';

package.json

@@ -1,17 +0,21 @@
-{ "name" : "socket.io"
-, "description" : "The cross-browser WebSocket"
-, "version" : "0.6.16"
-, "author" : "LearnBoost"
-, "licenses" :
-  [ { "type" : "MIT"
-    , "url" : "http://github.com/learnboost/Socket.IO-node/raw/master/README.md"
+{
+    "name": "socket.io"
+  , "description": "The cross-browser WebSocket"
+  , "version": "0.6.17"
+  , "author": "Guillermo Rauch <[e-mail]>"
+  , "contributors": [
+        { "name": "Guillermo Rauch", "email": "[e-mail]" }
+      , { "name": "Arnout Kazemier", "email": "[e-mail]" }
+    ]
+  , "licenses": [{
+        "type": "MIT"
+      , "url": "http://github.com/learnboost/Socket.IO-node/raw/master/README.md"
+    }]
+  , "repository": {
+        "type": "git"
+      , "url": "http://github.com/learnboost/Socket.IO-node.git"
     }
-  ]
-, "repository" :
-  { "type" : "git"
-  , "url" : "http://github.com/learnboost/Socket.IO-node.git"
-  }
-, "engine" : [ "node >=0.1.102" ]
-, "main" : "./index"
-, "scripts" : { "test" : "make test" }
+  , "engine": [ "node >=0.1.102" ]
+  , "main": "./index"
+  , "scripts": { "test" : "make test" }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8189660

increased by0.07%

Number of package files

792

increased by0.25%

Lines of code

15256

increased by0.5%

Worsened metrics

Number of low supply chain risk alerts

19

increased by11.76%

Number of medium supply chain risk alerts

24

increased by4.35%

No dependency changes