solid-js - npm Package Compare versions

Comparing version 1.7.0 to 1.7.1

dist/dev.js

@@ -1667,8 +1667,7 @@ let taskIdCounter = 1,
 
-let DEV;
-DEV = {
+const DEV = {
   hooks: DevHooks,
   writeSignal,
   registerGraph
-};
+} ;
 if (globalThis) {
@@ -1675,0 +1674,0 @@ if (!globalThis.Solid$$) globalThis.Solid$$ = true;else console.warn("You appear to have multiple instances of Solid. This can lead to unexpected behavior.");

dist/solid.js

@@ -1605,4 +1605,4 @@ let taskIdCounter = 1,
 
-let DEV;
+const DEV = undefined;
 
 export { $DEVCOMP, $PROXY, $TRACK, DEV, ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, batch, cancelCallback, catchError, children, createComponent, createComputed, createContext, createDeferred, createEffect, createMemo, createReaction, createRenderEffect, createResource, createRoot, createSelector, createSignal, createUniqueId, enableExternalSource, enableHydration, enableScheduling, equalFn, from, getListener, getOwner, indexArray, lazy, mapArray, mergeProps, observable, on, onCleanup, onError, onMount, requestCallback, resetErrorBoundaries, runWithOwner, sharedConfig, splitProps, startTransition, untrack, useContext, useTransition };

package.json

 {
   "name": "solid-js",
   "description": "A declarative JavaScript library for building user interfaces.",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "author": "Ryan Carniato",
@@ -6,0 +6,0 @@ "license": "MIT",

types/index.d.ts

@@ -11,3 +11,3 @@ export { $DEVCOMP, $PROXY, $TRACK, batch, children, createComputed, createContext, createDeferred, createEffect, createMemo, createReaction, createRenderEffect, createResource, createRoot, createSelector, createSignal, enableExternalSource, enableScheduling, equalFn, getListener, getOwner, on, onCleanup, onError, catchError, onMount, runWithOwner, startTransition, untrack, useContext, useTransition } from "./reactive/signal.js";
 import { registerGraph, writeSignal, DevHooks } from "./reactive/signal.js";
-declare let DEV: {
+declare const DEV: {
     readonly hooks: typeof DevHooks;
@@ -14,0 +14,0 @@ readonly writeSignal: typeof writeSignal;

web/dist/dev.js

@@ -1,2 +0,2 @@
-import { createRoot, createRenderEffect, sharedConfig, untrack, enableHydration, createMemo, createSignal, onMount, createEffect, onCleanup, splitProps, $DEVCOMP } from 'solid-js';
+import { createRoot, createRenderEffect, sharedConfig, untrack, enableHydration, getOwner, createEffect, runWithOwner, createSignal, onCleanup, splitProps, createMemo, $DEVCOMP } from 'solid-js';
 export { ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, createComponent, createRenderEffect as effect, getOwner, createMemo as memo, mergeProps, untrack } from 'solid-js';
@@ -575,11 +575,6 @@
     mount = () => props.mount || document.body,
-    content = createMemo(renderPortal());
-  function renderPortal() {
-    if (sharedConfig.context) {
-      const [s, set] = createSignal(false);
-      onMount(() => set(true));
-      return () => s() && props.children;
-    } else return () => props.children;
-  }
+    owner = getOwner();
+  let content;
   createEffect(() => {
+    content || (content = runWithOwner(owner, () => props.children));
     const el = mount();
@@ -589,3 +584,3 @@ if (el instanceof HTMLHeadElement) {
       const cleanup = () => setClean(true);
-      createRoot(dispose => insert(el, () => !clean() ? content() : dispose(), null));
+      createRoot(dispose => insert(el, () => !clean() ? content : dispose(), null));
       onCleanup(cleanup);
@@ -592,0 +587,0 @@ } else {

web/dist/web.js

@@ -1,2 +0,2 @@
-import { createRoot, createRenderEffect, sharedConfig, untrack, enableHydration, createMemo, createSignal, onMount, createEffect, onCleanup, splitProps, $DEVCOMP } from 'solid-js';
+import { createRoot, createRenderEffect, sharedConfig, untrack, enableHydration, getOwner, createEffect, runWithOwner, createSignal, onCleanup, splitProps, createMemo, $DEVCOMP } from 'solid-js';
 export { ErrorBoundary, For, Index, Match, Show, Suspense, SuspenseList, Switch, createComponent, createRenderEffect as effect, getOwner, createMemo as memo, mergeProps, untrack } from 'solid-js';
@@ -575,11 +575,6 @@
     mount = () => props.mount || document.body,
-    content = createMemo(renderPortal());
-  function renderPortal() {
-    if (sharedConfig.context) {
-      const [s, set] = createSignal(false);
-      onMount(() => set(true));
-      return () => s() && props.children;
-    } else return () => props.children;
-  }
+    owner = getOwner();
+  let content;
   createEffect(() => {
+    content || (content = runWithOwner(owner, () => props.children));
     const el = mount();
@@ -589,3 +584,3 @@ if (el instanceof HTMLHeadElement) {
       const cleanup = () => setClean(true);
-      createRoot(dispose => insert(el, () => !clean() ? content() : dispose(), null));
+      createRoot(dispose => insert(el, () => !clean() ? content : dispose(), null));
       onCleanup(cleanup);
@@ -592,0 +587,0 @@ } else {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

787088

decreased by-0.08%

Lines of code

21886

decreased by-0.1%

No dependency changes