spinjs - npm Package Compare versions

Comparing version 0.3.9 to 0.3.10

lib/executor.js

@@ -236,7 +236,8 @@ "use strict";
 }
-function openFrontend(builder) {
+function openFrontend(builder, logger) {
     var openurl = requireModule_1.default('openurl');
     try {
-        if (builder.stack.hasAny('web') && builder.openBrowser !== false) {
-            openurl.open("http://" + ip.address() + ":" + builder.config.devServer.port);
+        if (builder.stack.hasAny('web')) {
+            var url_1 = "http://" + ip.address() + ":" + builder.config.devServer.port;
+            openurl.open(url_1);
         }
@@ -366,3 +367,3 @@ else if (builder.stack.hasAny('react-native')) {
             frontendFirstStart = false;
-            openFrontend(builder);
+            openFrontend(builder, logger);
         }
@@ -369,0 +370,0 @@ });

package.json

 {
   "name": "spinjs",
-  "version": "0.3.9",
+  "version": "0.3.10",
   "scripts": {
@@ -35,2 +35,3 @@ "clean": "rm -rf ./lib",
   "dependencies": {
+    "containerized": "^1.0.2",
     "ip": "^1.1.5",
@@ -37,0 +38,0 @@ "lodash": "^4.17.4",

src/executor.ts

@@ -11,2 +11,3 @@ import * as http from 'http';
 import * as url from 'url';
+import * as containerized from 'containerized';
 import { fromStringWithSourceMap, SourceListMap } from 'source-list-map';
@@ -218,7 +219,12 @@ import { RawSource } from 'webpack-sources';
 
-function openFrontend(builder) {
+function openFrontend(builder, logger) {
     const openurl = requireModule('openurl');
     try {
-        if (builder.stack.hasAny('web') && builder.openBrowser !== false) {
-            openurl.open(`http://${ip.address()}:${builder.config.devServer.port}`);
+        if (builder.stack.hasAny('web')) {
+          const url = `http://${ip.address()}:${builder.config.devServer.port}`;
+          if (containerized() || builder.openBrowser === false) {
+            logger.info(`App is running at address: ${url}`);
+          } else {
+            openurl.open(url);
+          }
         } else if (builder.stack.hasAny('react-native')) {
@@ -356,3 +362,3 @@ startExpoProject(builder.config, builder.stack.platform);
             frontendFirstStart = false;
-            openFrontend(builder);
+            openFrontend(builder, logger);
         }
@@ -643,11 +649,12 @@ });
         });
-        if (platform === 'android') {
+        if (!containerized()) {
+          if (platform === 'android') {
             const {success, error} = await Android.openProjectAsync(projectRoot);
 
             if (!success) {
-                console.error(error.message);
+              console.error(error.message);
             }
-        } else if (platform === 'ios') {
+          } else if (platform === 'ios') {
             const localAddress = await UrlUtils.constructManifestUrlAsync(projectRoot, {
-                hostType: 'localhost',
+              hostType: 'localhost',
             });
@@ -657,4 +664,5 @@ const {success, msg} = await Simulator.openUrlInSimulatorSafeAsync(localAddress);
             if (!success) {
-                console.error('Failed to start Simulator: ', msg);
+              console.error('Failed to start Simulator: ', msg);
             }
+          }
         }
@@ -661,0 +669,0 @@ } catch (e) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

285804

increased by0.11%

Lines of code

4611

increased by0.2%

Worsened metrics

Dependency count

10

increased by11.11%

Dependency changes

• + Addedcontainerized@^1.0.2

• + Addedcontainerized@1.0.2(transitive)