sql - npm Package Compare versions

Comparing version 0.4.0 to 0.5.0

lib/node/query.js

@@ -73,3 +73,3 @@ 'use strict';
     this.whereClause = new Where();
-    this.whereClause.add(node);
+    this.whereClause.add( this.whereClause.expr(node) );
     return this.add(this.whereClause);
@@ -76,0 +76,0 @@ },

lib/node/where.js

 'use strict';
 
 var BinaryNode = require(__dirname + '/binary');
+var TextNode = require(__dirname + '/text');
 module.exports = require(__dirname).define({
   type: 'WHERE',
+  expr: function(other) {
+    return typeof other === 'string' ? new TextNode('('+other+')') : other;
+  },
   or: function(other) {
@@ -10,3 +14,3 @@ return this.nodes.push(new BinaryNode({
       operator: 'OR',
-      right: other
+      right: this.expr(other)
     }));
@@ -18,5 +22,5 @@ },
       operator: 'AND',
-      right: other
+      right: this.expr(other)
     }));
   }
 });

package.json

@@ -5,3 +5,3 @@ {
   "description": "sql builder",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "homepage": "https://github.com/brianc/node-sql",
@@ -8,0 +8,0 @@ "repository": {

test/dialects/table-tests.js

@@ -123,5 +123,5 @@ 'use strict';
   query : user.select('name').from('user').where('name <> NULL'),
-  pg    : 'SELECT name FROM user WHERE name <> NULL',
-  sqlite: 'SELECT name FROM user WHERE name <> NULL',
-  mysql : 'SELECT name FROM user WHERE name <> NULL',
+  pg    : 'SELECT name FROM user WHERE (name <> NULL)',
+  sqlite: 'SELECT name FROM user WHERE (name <> NULL)',
+  mysql : 'SELECT name FROM user WHERE (name <> NULL)',
   params: []
@@ -132,5 +132,5 @@ });
   query : user.select('name,id').from('user').where('name <> NULL'),
-  pg    : 'SELECT name,id FROM user WHERE name <> NULL',
-  sqlite: 'SELECT name,id FROM user WHERE name <> NULL',
-  mysql : 'SELECT name,id FROM user WHERE name <> NULL',
+  pg    : 'SELECT name,id FROM user WHERE (name <> NULL)',
+  sqlite: 'SELECT name,id FROM user WHERE (name <> NULL)',
+  mysql : 'SELECT name,id FROM user WHERE (name <> NULL)',
   params: []
@@ -141,4 +141,5 @@ });
   query : user.select('name','id').from('user').where('name <> NULL'),
-  pg    : 'SELECT name, id FROM user WHERE name <> NULL',
-  mysql : 'SELECT name, id FROM user WHERE name <> NULL',
+  pg    : 'SELECT name, id FROM user WHERE (name <> NULL)',
+  sqlite: 'SELECT name, id FROM user WHERE (name <> NULL)',
+  mysql : 'SELECT name, id FROM user WHERE (name <> NULL)',
   params: []
@@ -148,2 +149,10 @@ });
 Harness.test({
+  query : user.select('name','id').from('user').where('name <> NULL').and('id <> NULL'),
+  pg    : 'SELECT name, id FROM user WHERE ((name <> NULL) AND (id <> NULL))',
+  sqlite: 'SELECT name, id FROM user WHERE ((name <> NULL) AND (id <> NULL))',
+  mysql : 'SELECT name, id FROM user WHERE ((name <> NULL) AND (id <> NULL))',
+  params: []
+});
+
+Harness.test({
   query : user.select('name').from('user').where({name: 'brian'}),
@@ -150,0 +159,0 @@ pg    : 'SELECT name FROM user WHERE ("user"."name" = $1)',

No alert changes

Improved metrics

Total package byte prevSize

76356

increased by0.84%

Lines of code

2059

increased by0.59%

Worsened metrics

Number of low supply chain risk alerts

84

increased by1.2%

No dependency changes