storage-factory - npm Package Compare versions

Comparing version 0.0.1 to 0.0.2

lib/index.js

@@ -5,3 +5,10 @@ "use strict";
     let inMemoryStorage = {};
-    const length = 0;
+    const def = {
+        getItem,
+        setItem,
+        removeItem,
+        clear,
+        key,
+        length: 0
+    };
     function isSupported() {
@@ -25,2 +32,3 @@ try {
         }
+        updateLength();
     }
@@ -51,2 +59,3 @@ function getItem(name) {
         }
+        updateLength();
     }
@@ -60,12 +69,14 @@ function setItem(name, value) {
         }
+        updateLength();
     }
-    return {
-        getItem,
-        setItem,
-        removeItem,
-        clear,
-        key,
-        length,
-    };
+    function updateLength() {
+        if (isSupported()) {
+            def.length = storage.length;
+        }
+        else {
+            def.length = Object.keys(inMemoryStorage).length;
+        }
+    }
+    return def;
 }
 exports.storageFactory = storageFactory;

package.json

 {
   "name": "storage-factory",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "main": "lib/index.js",
@@ -18,3 +18,4 @@ "typings": "lib/index.d.ts",
     "build": "tsc",
-    "test": "jest"
+    "test": "jest",
+    "test:watch": "jest --watchAll"
   },
@@ -21,0 +22,0 @@ "jest": {

README.md

@@ -5,3 +5,3 @@ # storage-factory
 
-**Warning**: `length` property and array access are not yet implemented. PR welcome 🚀
+**Warning**: object access (e.g. `localStorage.foo`) is not yet implemented 💥
 
@@ -30,1 +30,5 @@ ## Usage
 ```
+
+## Contribute
+
+Do you want to contribute? Awesome! Please, create an issue first and tell me about it.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4014

increased by17.16%

Number of package files

5

increased by25%

Lines of code

79

increased by16.18%

Number of lines in readme file

33

increased by13.79%

No dependency changes