strava-v3 - npm Package Compare versions

Comparing version 1.1.0 to 1.2.0

index.js

@@ -8,5 +8,8 @@ /**
     , util = require('./lib/util')
+    , oauth = require('./lib/oauth')
     , athlete = require('./lib/athlete')
     , athletes = require('./lib/athletes')
     , activities = require('./lib/activities')
+    , clubs = require('./lib/clubs')
+    , gear = require('./lib/gear')
     ;
@@ -17,3 +20,3 @@
 
-//attempt to grab the default access_token
+//attempt to grab the default config
 try {
@@ -23,2 +26,3 @@ var config = fs.readFileSync(configPath, {encoding: 'utf-8'});
 } catch (err) {
+    //console.log(err)
     console.log("no 'data/strava_config' file, continuing without...");
@@ -28,5 +32,8 @@ }
 //assign various api segments to strava object
+strava.oauth = oauth;
 strava.athlete = athlete;
 strava.athletes = athletes;
 strava.activities = activities;
+strava.clubs = clubs;
+strava.gear = gear;
 
@@ -33,0 +40,0 @@ //and export

lib/activities.js

@@ -62,2 +62,3 @@ /**
     args.body = util.getRequestBodyObj(_updateAllowedProps,args);
+    console.log(args)
     util.putEndpoint(endpoint,args,done);
@@ -64,0 +65,0 @@ };

lib/athlete.js

@@ -34,3 +34,7 @@ /**
 };
+athlete.listClubs = function(args,done) {
 
+    this._listHelper("clubs",args,done);
+};
+
 athlete.update = function(args,done) {
@@ -37,0 +41,0 @@

lib/util.js

@@ -56,3 +56,3 @@ /**
     //stringify the body object for passage
-    var qs = querystring.stringify(args.body);
+    var qs = querystring.stringify(args.body);console.log(qs)
 
@@ -178,3 +178,3 @@ var url = this.endpointBase + endpoint
         if (!err) {
-            console.log(payload);
+            //console.log(payload);
         }
@@ -181,0 +181,0 @@ else {

package.json

 {
   "name": "strava-v3",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "Simple wrapper for strava v3 api",
@@ -25,6 +25,8 @@ "main": "index.js",
   "dependencies": {
+    "request": "^2.44.0"
+  },
+  "devDependencies": {
     "mocha": "^1.21.4",
-    "request": "^2.44.0",
     "should": "^4.0.4"
   }
 }

README.md

@@ -5,4 +5,11 @@
 ###Status
-Currently supporting all API calls to `athlete`, `athletes`, and `activities`.
+Currently supporting all API calls to endpoints: 
 
+* `oauth`
+* `athlete`
+* `athletes`
+* `activities`
+* `clubs`
+* `gear`
+
 ## Installation
@@ -25,5 +32,5 @@
 		strava = require('strava-v3');
-		strava.athletes.get({id:12345},function(err,payload) {
+		strava.athlete.get({},function(err,payload) {
 			if(!err) {			
-				//do something with your payload
+				console.log(payload);
 			}	
@@ -96,2 +103,10 @@ else {
 
+Oauth:
+
+* `strava.oauth.getRequestAccessURL(args)`
+* `strava.oauth.getToken(code,done)`
+* `strava.oauth.deauthorize(args,done)`
+
+Athlete:
+
 * `strava.athlete.get(args,done)`
@@ -102,2 +117,5 @@ * `strava.athlete.update(args,done)`
 * `strava.athlete.listActivities(args,done)`
+
+Athletes:
+
 * `strava.athletes.get(args,done)`
@@ -107,2 +125,5 @@ * `strava.athletes.listFriends(args,done)`
 * `strava.athletes.listKoms(args,done)`
+
+Activities:
+
 * `strava.activities.get(args,done)`
@@ -118,1 +139,10 @@ * `strava.activities.create(args,done)`
 * `strava.activities.listPhotos(args,done)`
+
+Clubs:
+* `strava.clubs.get(args,done)`
+* `strava.clubs.listMembers(args,done)`
+* `strava.clubs.listActivities(args,done)`
+
+Gear:
+* `strava.gear.get(args,done)`
+

test/activities.js

@@ -8,13 +8,26 @@ /**
 
-var activity_id = "196688702";
+var readWriteAccessToken = "34abbcf12450c3c964e141f463100fed33390872"
+    , testActivity = {}
+    ;
 
 describe('activities', function() {
 
-    describe('#get()', function () {
+    describe('#create()', function () {
 
-        it('should return information about the corresponding activity', function(done) {
-            strava.activities.get({id: activity_id}, function (err, payload) {
+        it('should create an activity', function(done) {
 
+            var args = {
+                name:"Most Epic Ride EVER!!!"
+                , elapsed_time:18373
+                , distance: 1557840
+                , start_date_local: "2013-10-23T10:02:13Z"
+                , type: "Ride"
+                , access_token: readWriteAccessToken
+            };
+
+            strava.activities.create(args, function (err, payload) {
+
                 if (!err) {
-                    //console.log(payload);
+                    console.log(payload);
+                    testActivity = payload;
                     (payload.resource_state).should.be.exactly(3);
@@ -27,3 +40,2 @@ }
                 done();
-
             });
@@ -33,16 +45,7 @@ });
 
-    describe('#create()', function () {
+    describe('#get()', function () {
 
-        it('should create an activity', function(done) {
+        it('should return information about the corresponding activity', function(done) {
+            strava.activities.get({id: testActivity.id}, function (err, payload) {
 
-            var args = {
-                name:"Most Epic Ride EVER!!!"
-                , elapsed_time:18373
-                , distance: 1557840
-                , start_date_local: "2013-10-23T10:02:13Z"
-                , type: "Ride"
-            };
-
-            strava.activities.create(args, function (err, payload) {
-
                 if (!err) {
@@ -57,2 +60,3 @@ //console.log(payload);
                 done();
+
             });
@@ -67,4 +71,6 @@ });
             var args = {
-                id:activity_id
+                id:testActivity.id
                 , description:"that description done been edited"
+                , name:"should've been running"
+                , access_token: readWriteAccessToken
             };
@@ -75,3 +81,3 @@
                 if (!err) {
-                    //console.log(payload);
+                    console.log(payload);
                     (payload.resource_state).should.be.exactly(3);
@@ -88,15 +94,11 @@ }
 
-    describe('#delete()', function () {
+    describe('#listZones()', function () {
 
-        it('should delete an activity', function(done) {
+        it('should list heart rate and power zones relating to activity', function(done) {
 
-            var args = {
-                id:"fakeID"
-            };
+            strava.activities.listZones({id:testActivity.id}, function (err, payload) {
 
-            strava.activities.delete(args, function (err, payload) {
-
                 if (!err) {
                     //console.log(payload);
-                    (payload.resource_state).should.be.exactly(3);
+                    payload.should.be.instanceof(Array);
                 }
@@ -112,7 +114,7 @@ else {
 
-    describe('#listFriends()', function () {
+    describe('#listLaps()', function () {
 
-        it('should list activities of friends associated to current athlete', function(done) {
+        it('should list laps relating to activity', function(done) {
 
-            strava.activities.listFriends({}, function (err, payload) {
+            strava.activities.listLaps({id:testActivity.id}, function (err, payload) {
 
@@ -132,7 +134,7 @@ if (!err) {
 
-    describe('#listZones()', function () {
+    describe('#listComments()', function () {
 
-        it('should list heartrate and power zones relating to activity', function(done) {
+        it('should list comments relating to activity', function(done) {
 
-            strava.activities.listZones({id:activity_id}, function (err, payload) {
+            strava.activities.listComments({id:testActivity.id}, function (err, payload) {
 
@@ -152,7 +154,7 @@ if (!err) {
 
-    describe.only('#listLaps()', function () {
+    describe('#listKudos()', function () {
 
-        it('should list laps relating to activity', function(done) {
+        it('should list kudos relating to activity', function(done) {
 
-            strava.activities.listLaps({id:activity_id}, function (err, payload) {
+            strava.activities.listKudos({id:testActivity.id}, function (err, payload) {
 
@@ -172,10 +174,10 @@ if (!err) {
 
-    describe('#listComments()', function () {
+    describe('#listPhotos()', function () {
 
-        it('should list comments relating to activity', function(done) {
+        it('should list photos relating to activity', function(done) {
 
-            strava.activities.listComments({id:activity_id}, function (err, payload) {
+            strava.activities.listPhotos({id:testActivity.id}, function (err, payload) {
 
                 if (!err) {
-                    //console.log(payload);
+                    console.log(payload);
                     payload.should.be.instanceof(Array);
@@ -192,13 +194,14 @@ }
 
-    describe('#listKudos()', function () {
+    describe('#delete()', function () {
 
-        it('should list kudos relating to activity', function(done) {
+        it('should delete an activity', function(done) {
 
-            strava.activities.listKudos({id:activity_id}, function (err, payload) {
+            var args = {
+                id:testActivity.id
+                , access_token: readWriteAccessToken
+            };
 
-                if (!err) {
-                    //console.log(payload);
-                    payload.should.be.instanceof(Array);
-                }
-                else {
+            strava.activities.delete(args, function (err, payload) {
+
+                if (err)  {
                     console.log(err);
@@ -212,10 +215,10 @@ }
 
-    describe.only('#listPhotos()', function () {
+    describe('#listFriends()', function () {
 
-        it('should list photos relating to activity', function(done) {
+        it('should list activities of friends associated to current athlete', function(done) {
 
-            strava.activities.listPhotos({id:activity_id}, function (err, payload) {
+            strava.activities.listFriends({}, function (err, payload) {
 
                 if (!err) {
-                    console.log(payload);
+                    //console.log(payload);
                     payload.should.be.instanceof(Array);
@@ -222,0 +225,0 @@ }

test/athlete.js

@@ -85,2 +85,21 @@
 
+    describe('#listClubs()', function() {
+
+        it('should return information about clubs associated to athlete with access_token', function(done) {
+
+            strava.athlete.listClubs({},function(err,payload){
+
+                if(!err) {
+                    //console.log(payload);
+                    payload.should.be.instanceof(Array);
+                }
+                else {
+                    console.log(err);
+                }
+
+                done();
+            });
+        });
+    });
+
     describe('#update()', function() {
@@ -87,0 +106,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

37428

increased by26.29%

Dependency count

1

decreased by-66.67%

Number of package files

26

increased by30%

Lines of code

919

increased by33.19%

Number of lines in readme file

143

increased by26.55%

Worsened metrics

Dev dependency count

2

increased byInfinity%

Dependency changes

• - Removedmocha@^1.21.4

• - Removedshould@^4.0.4

• - Removedcommander@0.6.12.3.0(transitive)

• - Removeddebug@2.0.0(transitive)

• - Removeddiff@1.0.8(transitive)

• - Removedescape-string-regexp@1.0.2(transitive)

• - Removedglob@3.2.3(transitive)

• - Removedgraceful-fs@2.0.3(transitive)

• - Removedgrowl@1.8.1(transitive)

• - Removedinherits@2.0.4(transitive)

• - Removedjade@0.26.3(transitive)

• - Removedlru-cache@2.7.3(transitive)

• - Removedminimatch@0.2.14(transitive)

• - Removedminimist@0.0.8(transitive)

• - Removedmkdirp@0.3.00.5.0(transitive)

• - Removedmocha@1.21.5(transitive)

• - Removedms@0.6.2(transitive)

• - Removedshould@4.6.5(transitive)

• - Removedshould-equal@0.3.1(transitive)

• - Removedshould-format@0.0.7(transitive)

• - Removedshould-type@0.0.4(transitive)

• - Removedsigmund@1.0.1(transitive)