superagent - npm Package Compare versions

Comparing version 3.3.0 to 3.3.1

History.md

@@ -0,1 +1,5 @@
+# 3.3.1 (2016-12-17)
+
+  * Fixed "double callback bug" warning on timeouts of gzipped responses
+
 # 3.3.0 (2016-12-14)
@@ -2,0 +6,0 @@

lib/node/index.js

@@ -843,2 +843,9 @@
         parser(res, function(err, obj, files) {
+          if (self.timedout) {
+            // Timeout has already handled all callbacks
+            return;
+          }
+
+          // Intentional (non-timeout) abort is supposed to preserve partial response,
+          // even if it doesn't parse.
           if (err && !self._aborted) {
@@ -845,0 +852,0 @@ return self.callback(err);

lib/node/unzip.js

@@ -8,13 +8,5 @@
 var Stream = require('stream');
-var zlib;
+var zlib = require('zlib');
 
 /**
- * Require zlib module for Node 0.6+
- */
-
-try {
-  zlib = require('zlib');
-} catch (e) { }
-
-/**
  * Buffers response data events and re-emits when they're unzipped.
@@ -28,4 +20,2 @@ *
 exports.unzip = function(req, res){
-  if (!zlib) return;
-
   var unzip = zlib.createUnzip();
@@ -32,0 +22,0 @@ var stream = new Stream;

package.json

 {
   "name": "superagent",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "description": "elegant & feature rich browser / node HTTP with a fluent API",
@@ -5,0 +5,0 @@ "scripts": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

488967

increased by0.19%

Number of package files

34

increased by3.03%

Lines of code

4303

increased by0.16%

No dependency changes